[rapidjson] Remove usage #18308
Merged
[rapidjson] Remove usage #18308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2021 02:19
JackBoosY
added
category:port-feature
|
@upsj Is that what you need? |
upsj
approved these changes
Jun 7, 2021
There was a problem hiding this comment.
@JackBoosY Thanks, that looks good! Somehow I didn't even notice the usage file 🤦♂️ I thought it was somehow autogenerated based on the exported cmake config.
added 2 commits
June 7, 2021 23:46
|
Now, the usage is printed automatically: The package rapidjson:x86-windows provides CMake targets:
find_package(RapidJSON CONFIG REQUIRED)
target_link_libraries(main PRIVATE rapidjson)
|
|
great, thanks :) |
WorkingRobot
pushed a commit
to WorkingRobot/vcpkg
that referenced
this pull request
Jul 12, 2021
* [rapidjson] Improve usage * update version record * Remove usage * update version record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage since the upstream export the target
rapidjson.Fixes #18292.