Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libuuid] Added cmake config and targets #18738

Merged
merged 15 commits into from
Jul 23, 2021
Merged

[libuuid] Added cmake config and targets #18738

merged 15 commits into from
Jul 23, 2021

Conversation

bucurb
Copy link
Contributor

@bucurb bucurb commented Jun 30, 2021

Describe the pull request

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 1, 2021
PhoebeHui
PhoebeHui requested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is unofficial targets, could you add the prefix 'unofficial-' to the configs and targets?

@bucurb bucurb requested a review from PhoebeHui July 1, 2021 10:51
PhoebeHui
PhoebeHui reviewed Jul 5, 2021
View reviewed changes
ports/libuuid/CONTROL Outdated Show resolved Hide resolved
@PhoebeHui PhoebeHui added requires:more-information This Issue requires more information to solve requires:author-response and removed requires:more-information This Issue requires more information to solve labels Jul 5, 2021
PhoebeHui
PhoebeHui reviewed Jul 7, 2021
View reviewed changes
versions/l-/libuuid.json Outdated Show resolved Hide resolved
dg0yt
dg0yt reviewed Jul 7, 2021
View reviewed changes
ports/libuuid/CMakeLists.txt Outdated Show resolved Hide resolved
ports/libuuid/unofficial-libuuid-config.cmake.in Outdated Show resolved Hide resolved
@bucurb bucurb requested a review from PhoebeHui July 8, 2021 16:10
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 9, 2021
@PhoebeHui
Copy link
Contributor

The failure in pistache:x64-linux would be fixed by #18994.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vicroms vicroms merged commit 22a15e3 into microsoft:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libuuid] Add CMake config & targets
5 participants
@bucurb @PhoebeHui @BillyONeal @dg0yt @vicroms