[curl] Update

[dg0yt]

Describe the pull request

• What does your PR fix?

  • Modernize and update port file
  • Improve pc file (no implict libs, no duplication, correctly choose optimized vs. debug e.g. for zlib, flatten transitive dependencies)
  • Install rectified curl-config for release and debug
  • Update curl (related: [curl] Update to 7.77.0 #16126)
  • Add WinIDN support
  • Revise libidn2 support (related: [libidn2] Fixes for mingw and minor issues #19002)
  • Fix winssl dependencies ([curl] build failure or rather configuration problem #19359)
  • Make WinLDAP an explicit, non-default feature
    Even with WinLDAP, there is no LDAPS support (Unable to compile curl with LDAPS #14030), which is now documented in the feature description.
    There are no vcpkg ports for supporting LDAP support on UWP and non-Windows platforms. With the explicit winldap feature, we can reliably deactivate ldap dependency lookups on these platforms (curl links against system libldap if installed #17919).

• Which triplets are supported/not supported? Have you updated the CI baseline?

  all, no

• Does your PR follow the maintainer guide?

  yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  yes

[dg0yt]

Curl now also supports "WinIDN" so this can be used for Windows instead of libidn2.
I will try to make IDN support work for mingw, too.
Libidn2 needs a review of how it publishes its icon and unistring dependencies.

[dg0yt]

I won't care much with the osx gdal issue before #17698 is merged.

[dg0yt]

Needs #19002 before submitting commit which re-adds proper libidn2 support.

[dg0yt]

Waiting for merge of
#19002 for libidn2 support
#17698 for osx gdal issue

[dg0yt]

I'm looking into upgrading to curl 0.78.0, and I want to get rid of the nghttp2 patch by #19163.

[dg0yt]

failed on x64-windows-static with the following errors

@NancyLi1013 Can you please verify that you are you using the latest version of port nghttp2? The static build should define NGHTTP2_STATICLIB at the end of include/nghttp2/nghttp2ver.h.

In CI, curl[core,http2,non-http,openssl,schannel,ssl,sspi,winssl]:x64-windows-static-md built just fine:
https://dev.azure.com/vcpkg/c1ee48cb-0df2-4ab3-8384-b1df5a79fe53/_apis/build/builds/57226/logs/117
(The agent for x64-windows-static died too early, but it reached curlpp so I assume there is no issue with curl[http2].)

[dg0yt]

Reset to draft for the following changes:

• fix winssl dependencies, [curl] build failure or rather configuration problem #19359.
• review non-http feature, cf. Unable to compile curl with LDAPS #14030 and curl links against system libldap if installed #17919.

What is wrong non-http:

• It is a default feature, making it hard to opt out. (Every port which depends on default features of curl pulls in non-http.)
  This wouldn't be a problem but
• It enables auto-discovery of libraries, so it may pick up system libraries, e.g. LDAP.

To ensure proper binary packages, we must disable each feature which has additional dependencies unless

• it is enabled by a non-default feature, and
• that feature adds proper dependencies

An additional feature "system-libraries" may allow the discovery of non-vcpkg libraries if desired. (Prototype: port gdal.)

[dg0yt]

* review `non-http` feature

I guess I checked this before: I don't see what other system libraries would be picked up by curl ATM. There are many default-OFF switches so this should all be safe.

[NancyLi1013]

Have you fixed the problem on feature http2?

[dg0yt]

Have you fixed the problem on feature http2?

I asked you to double-check that you tested the feature with the latest version of port nghttp2. May I kindly repeat my request?
CI didn't find any problem when I did a test build with the http2 enabled, as I reported in another comment here.

[NancyLi1013]

Have you fixed the problem on feature http2?

I asked you to double-check that you tested the feature with the latest version of port nghttp2. May I kindly repeat my request?
CI didn't find any problem when I did a test build with the http2 enabled, as I reported in another comment here.

I tested this feature based on your branch. nghttp2 is 1.42.0, the latest version in vcpkg master branch is 1.44.0. I think you need to merge master to your branch.

[dg0yt]

I think you need to merge master to your branch.

Oh, you test the HEAD of this branch without master. That's different from CI, of course. I did the merge now. But you could do this as well when testing. (Or should do it that way? It you test just the branch, it is different from what the user gets after the PR is merged.)

[NancyLi1013]

I think you need to merge master to your branch.

Oh, you test the HEAD of this branch without master. That's different from CI, of course. I did the merge now. But you could do this as well when testing. (Or should do it that way? It you test just the branch, it is different from what the user gets after the PR is merged.)

I have update to the latest changes to test the feature http2. It can be built successfully on x64-windows-static now.

[NancyLi1013]

LGTM now, thanks for your updates and improvements @dg0yt.

[JackBoosY]

Fixes #14030.

[BillyONeal]

Thanks for your hard work!