Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libxml2] Fix build error on uwp #19221

Merged

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Related https://github.com/microsoft/vcpkg/pull/17945/files#r678821283
#18827 (comment)

Currently, libxml2 build failed on uwp, which caused those ports that depends on libxml2 also cannot build on uwp.

So add a patch to fix the problem.

Note: Feature tools has passed on arm-uwp.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 29, 2021
@cenit
Copy link
Contributor

cenit commented Jul 29, 2021

is ci.baseline.txt ok? you told me libxml2 was excluded also there for uwp

@NancyLi1013
Copy link
Contributor Author

is ci.baseline.txt ok? you told me libxml2 was excluded also there for uwp

There is no libxml2 in ci.baseline.txt. So I just removed supports: !uwp in vcpkg.json.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 30, 2021
@dan-shaw dan-shaw merged commit fb24bdc into microsoft:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants