Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[signalrclient]Update homepage URL #19256

Merged
merged 4 commits into from
Aug 5, 2021
Merged

Conversation

BrennanConroy
Copy link
Member

https://github.com/aspnet/SignalR-Client-Cpp is for the newer microsoft-signalr package.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for signalrclient but no changes to version or port version.
-- Version: 1.0.0-beta1-9
-- Old SHA: dbe638f959b879da354861fb39b3d4dbb179ea7d
-- New SHA: dbddf4175663355eea96e5474d904fc08bda4847
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@JonLiu1993 JonLiu1993 self-assigned this Aug 2, 2021
@JonLiu1993 JonLiu1993 changed the title Fix incorrect homepage URL [signalrclient]Update homepage URL Aug 2, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 2, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for signalrclient but no changes to version or port version.
-- Version: 1.0.0-beta1-9
-- Old SHA: dbe638f959b879da354861fb39b3d4dbb179ea7d
-- New SHA: dbddf4175663355eea96e5474d904fc08bda4847
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout fa1bbe097b26678e3fd992173b62279c071c422b -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/signalrclient.json b/versions/s-/signalrclient.json
index 66a3e16..fadf04d 100644
--- a/versions/s-/signalrclient.json
+++ b/versions/s-/signalrclient.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "dbddf4175663355eea96e5474d904fc08bda4847",
+      "git-tree": "dbe638f959b879da354861fb39b3d4dbb179ea7d",
       "version-string": "1.0.0-beta1-9",
       "port-version": 0
     },

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout fa1bbe097b26678e3fd992173b62279c071c422b -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/signalrclient.json b/versions/s-/signalrclient.json
index 3d00387..4d3e06f 100644
--- a/versions/s-/signalrclient.json
+++ b/versions/s-/signalrclient.json
@@ -5,6 +5,11 @@
       "version-string": "1.0.0-beta1-9",
       "port-version": 1
     },
+    {
+      "git-tree": "dbe638f959b879da354861fb39b3d4dbb179ea7d",
+      "version-string": "1.0.0-beta1-9",
+      "port-version": 0
+    },
     {
       "git-tree": "134ed01f4047d9dcb077f5f0bf06d07b374fe7b1",
       "version-string": "1.0.0-beta1-8",

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 2, 2021
@dan-shaw dan-shaw merged commit 84d892a into microsoft:master Aug 5, 2021
@BrennanConroy BrennanConroy deleted the patch-1 branch August 5, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants