[workflow] Update version to 0.9.6 #19280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JonLiu1993
added
the
category:port-update
JonLiu1993
changed the title
JonLiu1993
requested changes
Aug 2, 2021
ports/workflow/vcpkg.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "workflow", | |||
| "version": "0.9.5", | |||
| "version": "0.9.6", | |||
| "port-version": 1, | |||
There was a problem hiding this comment.
Suggested change
| "port-version": 1, |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 261c458af6e3eed5d099144aff95d2b5035f656b -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/w-/workflow.json b/versions/w-/workflow.json
index 3adb15b..725cdd2 100644
--- a/versions/w-/workflow.json
+++ b/versions/w-/workflow.json
@@ -5,11 +5,6 @@
"version": "0.9.6",
"port-version": 0
},
- {
- "git-tree": "b3f929dcfa8c14b9d70471c159dcd9a0ee3c0a8d",
- "version": "0.9.6",
- "port-version": 1
- },
{
"git-tree": "3771249036075b8138d0e34de9799ca4571b1867",
"version": "0.9.5",
JonLiu1993
requested changes
Aug 2, 2021
versions/w-/workflow.json
Outdated
Comment on lines
8
to
12
| { | ||
| "git-tree": "b3f929dcfa8c14b9d70471c159dcd9a0ee3c0a8d", | ||
| "version": "0.9.6", | ||
| "port-version": 1 | ||
| }, |
There was a problem hiding this comment.
Suggested change
| { | |
| "git-tree": "b3f929dcfa8c14b9d70471c159dcd9a0ee3c0a8d", | |
| "version": "0.9.6", | |
| "port-version": 1 | |
| }, |
There was a problem hiding this comment.
We only need to add "version" once when submitting pr
This reverts commit 487548a.
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 261c458af6e3eed5d099144aff95d2b5035f656b -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index aed4af1..895f9d5 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6714,7 +6714,7 @@
},
"workflow": {
"baseline": "0.9.6",
- "port-version": 1
+ "port-version": 0
},
"wpilib": {
"baseline": "2020.3.2",
diff --git a/versions/w-/workflow.json b/versions/w-/workflow.json
index 4eb4176..725cdd2 100644
--- a/versions/w-/workflow.json
+++ b/versions/w-/workflow.json
@@ -1,9 +1,9 @@
{
"versions": [
{
- "git-tree": "b3f929dcfa8c14b9d70471c159dcd9a0ee3c0a8d",
+ "git-tree": "8a8abc2f5725ad78500a5edd20df2c73ee2ddc37",
"version": "0.9.6",
- "port-version": 1
+ "port-version": 0
},
{
"git-tree": "3771249036075b8138d0e34de9799ca4571b1867",
JonLiu1993
approved these changes
Aug 3, 2021
JonLiu1993
added
info:reviewed
ras0219
reviewed
Aug 3, 2021
ports/workflow/portfile.cmake
Outdated
| @@ -2,16 +2,16 @@ if(VCPKG_TARGET_IS_WINDOWS AND NOT VCPKG_TARGET_IS_MINGW) | |||
| vcpkg_from_github( | |||
| OUT_SOURCE_PATH SOURCE_PATH | |||
| REPO sogou/workflow | |||
| REF 268c873d20b5cddedcf1d36fe9c2af8338353a98 | |||
| SHA512 07b61657e34c1bce1f0fb8314e9d531e43dd9bf6004d6c67aaad9fcafa2073e05b835b85e87c82c26ca828edca08e9960a25578830657b9909b28bfa75cac6cc | |||
| REF e411d98144a56e2c2ffe4ee878f3b4e8a2cf9442 | |||
There was a problem hiding this comment.
This commit seems much newer than 0.9.6 with several functional changes applied. We want to avoid cross-platform users being confused about things working on one platform but not working on another.
Is there a closer commit to v0.9.6 that's appropriate to use here instead? Perhaps sogou/workflow@b9919bc ?
There was a problem hiding this comment.
The core functions are consistent. It's fine. Thanks!
JonLiu1993
added
requires:author-response
and removed
info:reviewed
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 261c458af6e3eed5d099144aff95d2b5035f656b -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/w-/workflow.json b/versions/w-/workflow.json
index 725cdd2..c621401 100644
--- a/versions/w-/workflow.json
+++ b/versions/w-/workflow.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "8a8abc2f5725ad78500a5edd20df2c73ee2ddc37",
+ "git-tree": "ab1da719c3684f213ddd140aa6e09994c73580ee",
"version": "0.9.6",
"port-version": 0
},
|
I have communicated with the maintainer of workflow. We think this REF is consistent with the Release v0.9.6 on branch master. |
JonLiu1993
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.