-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[angle] Fix mingw build #19307
[angle] Fix mingw build #19307
Conversation
qt5-base doesn't use angle on windows?! |
SET_TARGET_PROPERTIES(libANGLE PROPERTIES PREFIX "") | ||
SET_TARGET_PROPERTIES(libGLESv2 PROPERTIES PREFIX "") | ||
SET_TARGET_PROPERTIES(libEGL PROPERTIES PREFIX "") | ||
set_target_properties(libANGLE PROPERTIES PREFIX "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't libANGLE
be given a similar IMPORT_PREFIX ""
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libANGLE
is STATIC
so there is no import library:
vcpkg/ports/angle/CMakeLists.txt
Line 537 in a863c84
add_library(libANGLE STATIC ${LIBANGLE_SOURCES}) |
@ras0219 Do you have an idea why it is not supported for windows? vcpkg/ports/qt5-base/vcpkg.json Lines 7 to 11 in a863c84
|
on windows the default is always to use |
What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
no change, no.
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes
Disclaimer: not tested with actual app, just another step towards building Qt.