[tinyfiledialogs] Fix for good #19338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
strega-nil-ms
added
category:port-bug
ras0219
reviewed
Aug 3, 2021
BillyONeal
reviewed
Aug 3, 2021
BillyONeal
approved these changes
Aug 3, 2021
JackBoosY
reviewed
Aug 4, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Closed for rollup #19469. |
strega-nil-ms
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
Aug 11, 2021
[tinyfiledialogs] Fix for good
strega-nil-ms
added a commit
that referenced
this pull request
Aug 16, 2021
* [rollup:2021-08-09] PR #16706 (@JackBoosY) [vcpkg_fixup_cmake_targets] Fix up OSX system development path * [rollup:2021-08-09] PR #19238 (@strega-nil) [scripts-audit] vcpkg_download_distfile * [rollup:2021-08-09] PR #19239 (@strega-nil) [scripts-audit] vcpkg_find_fortran * [rollup:2021-08-09] PR #19338 (@strega-nil) [tinyfiledialogs] Fix for good * [rollup:2021-08-09] PR #19348 (@strega-nil) [scripts-audit] vcpkg_fixup_pkgconfig * fix ports.cmake with newer vcpkg_download_distfile * fix vcpkg create * move vcpkg_common_definitions down so that it's not incorrect * fix vcpkg_internal_get_cmake_vars Co-authored-by: nicole mazzuca <mazzucan@outlook.com> Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
mahge
added a commit
to mahge/vcpkg
that referenced
this pull request
Nov 3, 2021
- The directory specified no longer matches the directory used for
fetching.
- This was overlooked by PR microsoft#19338.
BillyONeal
added a commit
that referenced
this pull request
Nov 26, 2021
- The directory specified no longer matches the directory used for
fetching.
- This was overlooked by PR #19338.
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stabilizes the source access for tinyfiledialogs, so we no longer have to worry about it being inaccessible or changed.
It adds a new parameter to
vcpkg_from_git,FETCH_REF, which tells vcpkg to instead fetch that branch in a non-shallow way. In almost all cases, unless the upstream rebases their entire history, this will allow us to avoid the issue of downloading non-advertised objects, which many git servers do not support.This was originally part of #19207, but I didn't want to have to rebuild the world on that PR.