[libconfig] build on macos #19374
Merged
[libconfig] build on macos #19374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jamesathey
force-pushed
the
libconfig-build-on-macos
branch
from
6e9f1d5 to
318ff58
Compare
JackBoosY
added
the
category:port-feature
JackBoosY
suggested changes
Aug 5, 2021
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* remove "find_path(STDINT_H stdint.h)". On clang/macos, this picks up the kernel headers version of stdint.h, instead of the C standard library, breaking compilation * only define YY_NO_UNISTD_H and YY_USE_CONST on Windows, like the upstream CMakeLists.txt * set the C standard to C99, like the upstream CMakeLists.txt * update to 1.7.3 * remove the "fail" line from ci.baseline.txt * run ./vcpkg x-add-version --all to update metadata files * reset port-version
jamesathey
force-pushed
the
libconfig-build-on-macos
branch
from
318ff58 to
c31ada0
Compare
|
I think it's good. Please click |
JackBoosY
approved these changes
Aug 6, 2021
|
If #5518 were still open and not closed wont-fix, this PR would fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes compilation errors on macOS by making the compilation flags better match what the upstream libconfig CMakeLists.txt is doing. In particular, the line
find_path(STDINT_H stdint.h)was picking up the kernel header version ofstdint.hon macOS, altering the header search paths and preventing libconfig from compiling against the C standard library.Also updates the library to the latest patch release (1.7.2 -> 1.7.3).
Which triplets are supported/not supported? Have you updated the CI baseline?
This PR addresses the build failure on macOS, so this PR also removes the "fail" line from
ci.baseline.txt.Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.