Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pybind11] Update to 2.7.1 #19375

Merged
merged 11 commits into from
Aug 10, 2021
Merged

Conversation

Ryan-rsm-McKenzie
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Updates pybind11 to 2.7.1

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Just an update

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@JonLiu1993 JonLiu1993 self-assigned this Aug 5, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 5, 2021
ports/pybind11/portfile.cmake Outdated Show resolved Hide resolved
ports/pybind11/portfile.cmake Outdated Show resolved Hide resolved
ports/pybind11/portfile.cmake Outdated Show resolved Hide resolved
ports/pybind11/portfile.cmake Outdated Show resolved Hide resolved
@JonLiu1993
Copy link
Member

@Ryan-rsm-McKenzie ,Thank for your update,we need to use the new cmake function to update the port in the future, and only need to add "" to the path in the portfile.cmake file.

@Ryan-rsm-McKenzie
Copy link
Contributor Author

What do you mean by the new cmake function?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout d2019e507caf9469d8d5c93bfcd3f6d26548ca12 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/p-/pybind11.json b/versions/p-/pybind11.json
index ea9837f..2a54f4b 100644
--- a/versions/p-/pybind11.json
+++ b/versions/p-/pybind11.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "8059ca1cdd3256e6fd517ceb558fcba3ac33eb02",
+      "git-tree": "a8d7e31e74a9d73e4956e70efbcc0c3490968883",
       "version-semver": "2.7.1",
       "port-version": 0
     },

@JonLiu1993
Copy link
Member

What do you mean by the new cmake function?

Like "vcpkg_cmake_install","vcpkg_cmake_configure"

OPTIONS_RELEASE
-DPYTHON_IS_DEBUG=OFF
OPTIONS_DEBUG
-DPYTHON_IS_DEBUG=ON
)

vcpkg_install_cmake()
vcpkg_fixup_cmake_targets(CONFIG_PATH share/cmake/pybind11)
vcpkg_cmake_install()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pybind11 doesn't install a pkgconfig file.

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 6, 2021
@dan-shaw dan-shaw merged commit bd66dde into microsoft:master Aug 10, 2021
@Ryan-rsm-McKenzie Ryan-rsm-McKenzie deleted the pybind11 branch August 13, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants