[libarchive] Restore pkgconfig file #19428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
added
category:port-bug
JackBoosY
suggested changes
Aug 9, 2021
So far, generating libarchive.pc has been disabled by the fix-buildsystem.patch, whereas INCLUDE(CreatePkgConfigFile) has been removed from CMakeLists.txt - Update fix-buildsystem.patch and allow creating the pkgconfig file - Add vcpkg_fixup_pkgconfig() to portfile - Add `FEATURES` keyword to vcpkg_check_features() to avoid deprecation warning
c72578
force-pushed
the
2021-08-05_libarchive_restore_pkgconfig_file
branch
from
171547d to
23aa5e1
Compare
JackBoosY
approved these changes
Aug 9, 2021
JackBoosY
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
So far, generating
libarchive.pchas been disabled by thefix-buildsystem.patch, whereas
INCLUDE(CreatePkgConfigFile)was removedfrom
CMakeLists.txtvcpkg_fixup_pkgconfig()to portfileFEATURESkeyword tovcpkg_check_features()to avoid deprecationwarning
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?YesIf you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/