Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cppitertools] update to version 2.1 #19437

Merged
merged 4 commits into from
Aug 9, 2021
Merged

[cppitertools] update to version 2.1 #19437

merged 4 commits into from
Aug 9, 2021

Conversation

Roy-Fokker
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

Updates CppIterTools port to version 2.1

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Should work for all triplets. But tested only on windows. Don't have other environments to test on.

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    I think i did this correctly.

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5742e878fc71b4fcb9c019b50f1f887f22db58df -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/c-/cppitertools.json b/versions/c-/cppitertools.json
index cb19009..1aaf441 100644
--- a/versions/c-/cppitertools.json
+++ b/versions/c-/cppitertools.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "9b4908a6183e914b33014a6b2f640df56e99d9f0",
+      "version-string": "2.1",
+      "port-version": 0
+    },
     {
       "git-tree": "6f5ac65e92858f04e97468de01d59b60c0eac058",
       "version-string": "2.0",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5742e878fc71b4fcb9c019b50f1f887f22db58df -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 19650fa..342cbde 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1449,7 +1449,7 @@
       "port-version": 0
     },
     "cppitertools": {
-      "baseline": "2.0",
+      "baseline": "2.1",
       "port-version": 0
     },
     "cppkafka": {
diff --git a/versions/c-/cppitertools.json b/versions/c-/cppitertools.json
index cb19009..1aaf441 100644
--- a/versions/c-/cppitertools.json
+++ b/versions/c-/cppitertools.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "9b4908a6183e914b33014a6b2f640df56e99d9f0",
+      "version-string": "2.1",
+      "port-version": 0
+    },
     {
       "git-tree": "6f5ac65e92858f04e97468de01d59b60c0eac058",
       "version-string": "2.0",

@Roy-Fokker Roy-Fokker marked this pull request as ready for review August 7, 2021 23:30
@JonLiu1993 JonLiu1993 self-assigned this Aug 9, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 9, 2021
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 9, 2021
@dan-shaw dan-shaw merged commit e328617 into microsoft:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants