Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[intel-mkl] Update description field #19461

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Add the information that users need to install MKL manually to description field.

Note that please download and install MKL from https://registrationcenter.intel.com/en/products/download/3178/ manually before using it in vcpkg.

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Aug 9, 2021
Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 57bd7102d9fd880daa1b0958692294c4a125f6d8 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/i-/intel-mkl.json b/versions/i-/intel-mkl.json
index 36f844b..1c5ffb0 100644
--- a/versions/i-/intel-mkl.json
+++ b/versions/i-/intel-mkl.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "88fbc68eed77db424c50b2d4796a6478524ba0c7",
+      "git-tree": "f2d5b828df130d8b1106aa0c076eb9cb79e50ea9",
       "version": "2020.0.0",
       "port-version": 2
     },

@NancyLi1013
Copy link
Contributor Author

Probably:
https://software.intel.com/content/www/us/en/develop/tools/oneapi/base-toolkit/download.html?operatingsystem=window&distributions=webdownload&options=offline

Thanks for your suggestion. @Neumann-A

Since https://registrationcenter.intel.com/en/products/download/3178/ is also used in portfile.cmake, it would be better to keep the consistent with this in vcpkg.json.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 10, 2021
@BillyONeal BillyONeal merged commit eba4f2c into microsoft:master Aug 12, 2021
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[intel-mkl] build failure using GitHub Actions (MSBuild based project)
4 participants