-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keystone] Fix static build with dynamic CRT on Windows #19491
Merged
BillyONeal
merged 7 commits into
microsoft:master
from
NancyLi1013:dev/NancyLi/fix-keystone
Aug 12, 2021
Merged
[keystone] Fix static build with dynamic CRT on Windows #19491
BillyONeal
merged 7 commits into
microsoft:master
from
NancyLi1013:dev/NancyLi/fix-keystone
Aug 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
labels
Aug 11, 2021
JackBoosY
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 69478c5caafcde4c490bb1fccb960296801dbb5f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/k-/keystone.json b/versions/k-/keystone.json
index e571bc3..7f8c71f 100644
--- a/versions/k-/keystone.json
+++ b/versions/k-/keystone.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "b44b0717c7ac7badb9565ed07b7d12a0b67c2a8a",
+ "git-tree": "34865a7cf3fbcf4f104e8b136862aa8acc1a7ca7",
"version-semver": "0.9.2",
"port-version": 1
},
JackBoosY
approved these changes
Aug 11, 2021
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes Keystone build failure (static/mixed/dynamic CRT/CMake). #19473
Fix build error on x64-windows-static-md
Remove unused codes
Add
vcpkg_fixup_pkgconfig()
Update the deprecated functions
Add
supports
fieldNote: No feature needs to test.