Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keystone] Fix static build with dynamic CRT on Windows #19491

Merged
merged 7 commits into from
Aug 12, 2021

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 11, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 69478c5caafcde4c490bb1fccb960296801dbb5f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/k-/keystone.json b/versions/k-/keystone.json
index e571bc3..7f8c71f 100644
--- a/versions/k-/keystone.json
+++ b/versions/k-/keystone.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "b44b0717c7ac7badb9565ed07b7d12a0b67c2a8a",
+      "git-tree": "34865a7cf3fbcf4f104e8b136862aa8acc1a7ca7",
       "version-semver": "0.9.2",
       "port-version": 1
     },

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 11, 2021
@BillyONeal BillyONeal merged commit c315cf9 into microsoft:master Aug 12, 2021
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keystone build failure (static/mixed/dynamic CRT/CMake).
3 participants