-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[immer] update port #19521
[immer] update port #19521
Conversation
The CI shows a regression, but it seems to be related to my
|
vcpkg_cmake_configure and vcpkg_cmake_install provided by vcpkg-cmake port. |
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 63aa65e65b9d2c08772ea15d25fb8fdb0d32e557 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index b0f7b57..9ba7997 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2694,7 +2694,7 @@
},
"immer": {
"baseline": "2021-05-03",
- "port-version": 2
+ "port-version": 0
},
"implot": {
"baseline": "0.11",
diff --git a/versions/i-/immer.json b/versions/i-/immer.json
index 68850cd..0ab115f 100644
--- a/versions/i-/immer.json
+++ b/versions/i-/immer.json
@@ -1,9 +1,9 @@
{
"versions": [
{
- "git-tree": "109831691a62c81c985e8652aa7e1f073d776660",
- "version-string": "2021-05-03",
- "port-version": 2
+ "git-tree": "0ee78459721140ead0ace0a031bbb9d28039b19e",
+ "version-date": "2021-05-03",
+ "port-version": 0
},
{
"git-tree": "515103042c70e0f9cf8d1518816d09fc6110a669",
Thanks for your pr,please run command "./vcpkg x-add-version immer --overwrite-version" then commit the changes again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 63aa65e65b9d2c08772ea15d25fb8fdb0d32e557 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/i-/immer.json b/versions/i-/immer.json
index f22fb87..0ab115f 100644
--- a/versions/i-/immer.json
+++ b/versions/i-/immer.json
@@ -5,11 +5,6 @@
"version-date": "2021-05-03",
"port-version": 0
},
- {
- "git-tree": "109831691a62c81c985e8652aa7e1f073d776660",
- "version-string": "2021-05-03",
- "port-version": 2
- },
{
"git-tree": "515103042c70e0f9cf8d1518816d09fc6110a669",
"version-string": "2019-06-07",
@waybeforenow, If pr is ready for review please let me know |
I've marked it as ready for review now. |
Feature docs tested successfully in the following triplet:
|
Describe the pull request
What does your PR fix?
Immer port was previously out of date.
Which triplets are supported/not supported? Have you updated the CI baseline?
I have tested
x86-linux
, and there appears to be no incompatible triplets.Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/