Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rtaudio] update #19583

Merged
merged 2 commits into from
Aug 19, 2021
Merged

[rtaudio] update #19583

merged 2 commits into from
Aug 19, 2021

Conversation

autoantwort
Copy link
Contributor

The new version exports cmake targets

@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 16, 2021
@NancyLi1013
Copy link
Contributor

Have you tested the feature asio and also the usage for cmake targets? @autoantwort

@NancyLi1013 NancyLi1013 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Aug 16, 2021
@autoantwort
Copy link
Contributor Author

I cant test the asio feature, because i don't have windows. I have tested the cmake targets

@NancyLi1013
Copy link
Contributor

Feature asio has passed with the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Aug 17, 2021
@dan-shaw dan-shaw merged commit 75d6f76 into microsoft:master Aug 19, 2021
@autoantwort autoantwort deleted the update-rtaudio branch September 1, 2021 14:00
@dyfer dyfer mentioned this pull request Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autoantwort @NancyLi1013 @dan-shaw