Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg_fixup_pkgconfig] HOTFIX -- revert #19469 #19607

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

ras0219
Copy link
Contributor

@ras0219 ras0219 commented Aug 17, 2021

PR #19469 regressed pkgconfig for libcurl. This was not detected because it also regressed the self-check mechanism (removed argument from vcpkg_fixup_pkgconfig_check_files without removing the argument from the callers).

Because there are a large number of changes in the helper and the internal consistency check was disabled, I'm reverting the entire change so it can go through a proper separate PR process again.

Fixes #19606

@ras0219-msft
Copy link
Contributor

Bypassing full CI check because this is a revert back to a known good state. I've manually reviewed the changes in #19469 to ensure that this file can be independently rolled back.

@ras0219-msft ras0219-msft merged commit d679a1e into microsoft:master Aug 17, 2021
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Aug 17, 2021
@ras0219-msft ras0219-msft deleted the dev/roschuma/revert branch August 17, 2021 21:26
@dg0yt
Copy link
Contributor

dg0yt commented Aug 18, 2021

Thanks for the quick fix.
For the record, port gdal heavily depends on pkgconfig files, and I intentionally added configuration verification to the portfile because I thought this could be fragile. Now on the first true positive alert from the gdal alert bells, it was ignored although the CI logs provided clear hints. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Curl] libcurl.pc in pkgconfig are broken for linux and android.
3 participants