-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pcre] Remove download from ftp.pcre.org #21225
[pcre] Remove download from ftp.pcre.org #21225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/pcre/portfile.cmake
e39d398
to
1aa0d9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/pcre/portfile.cmake
1aa0d9e
to
9cb7077
Compare
9cb7077
to
6916d65
Compare
6916d65
to
37cd246
Compare
The former ftp.pcre.org FTP site is no longer available [1]. - Use sourceforge only for download - Fixes microsoft#21201 - Remove deprecated functions from portfile vcpkg_install_cmake -> vcpkg_cmake_install vcpkg_configure_cmake -> vcpkg_cmake_configure (remove PREFER_NINJA) vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup - Add double quotes to files [1] https://www.pcre.org/
37cd246
to
b68c9d0
Compare
LGTM, thanks for your fixes. @c72578 |
Describe the pull request
What does your PR fix?
The former ftp.pcre.org FTP site is no longer available [1].
vcpkg_install_cmake
->vcpkg_cmake_install
vcpkg_configure_cmake
->vcpkg_cmake_configure
(removedPREFER_NINJA
)vcpkg_fixup_cmake_targets
->vcpkg_cmake_config_fixup
[1] https://www.pcre.org/
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/