Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlpack] Fix supports #21316

Merged
merged 5 commits into from
Dec 10, 2021
Merged

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Update supports: uwp as supports: !uwp. This is caused by mistake via PR #17983.

@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Nov 11, 2021
@JackBoosY
Copy link
Contributor

That's my fault, sorry.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Nov 11, 2021
@JackBoosY
Copy link
Contributor

CMake Error at /mnt/vcpkg-ci/installed/x64-linux/share/Armadillo/ArmadilloConfig.cmake:12 (include):
  include could not find requested file:

    /share/Armadillo/ArmadilloLibraryDepends.cmake
Call Stack (most recent call first):
  /agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:788 (_find_package)
  CMakeLists.txt:294 (find_package)

@JackBoosY
Copy link
Contributor

Depends on #20439.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Nov 11, 2021
@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label Nov 11, 2021
@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 10, 2021
@JackBoosY
Copy link
Contributor

I will take over this PR.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd4169a47f70aa83b8993b3b74e461eb64327de8 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/mlpack.json b/versions/m-/mlpack.json
index 65090fd..4cd54ba 100644
--- a/versions/m-/mlpack.json
+++ b/versions/m-/mlpack.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "e0f7e5146cb0e05db15029e44803bac6d3c09a00",
+      "git-tree": "e2b1db0b884f2df889d1aae23e76fb00f6570f28",
       "version": "3.4.1",
       "port-version": 3
     },

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd4169a47f70aa83b8993b3b74e461eb64327de8 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/mlpack.json b/versions/m-/mlpack.json
index 65090fd..e1d1ad6 100644
--- a/versions/m-/mlpack.json
+++ b/versions/m-/mlpack.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "e0f7e5146cb0e05db15029e44803bac6d3c09a00",
+      "git-tree": "aa79e1e52ba4e3112b84d77bc321580988b945f0",
       "version": "3.4.1",
       "port-version": 3
     },

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Dec 10, 2021
@BillyONeal BillyONeal merged commit 36c0baf into microsoft:master Dec 10, 2021
@BillyONeal
Copy link
Member

Ouch, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mlpack build failure
4 participants