-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mlpack] Fix supports #21316
[mlpack] Fix supports #21316
Conversation
That's my fault, sorry. |
|
Depends on #20439. |
I will take over this PR. |
…NancyLi/fix-mlpack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd4169a47f70aa83b8993b3b74e461eb64327de8 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/mlpack.json b/versions/m-/mlpack.json
index 65090fd..4cd54ba 100644
--- a/versions/m-/mlpack.json
+++ b/versions/m-/mlpack.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "e0f7e5146cb0e05db15029e44803bac6d3c09a00",
+ "git-tree": "e2b1db0b884f2df889d1aae23e76fb00f6570f28",
"version": "3.4.1",
"port-version": 3
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd4169a47f70aa83b8993b3b74e461eb64327de8 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/mlpack.json b/versions/m-/mlpack.json
index 65090fd..e1d1ad6 100644
--- a/versions/m-/mlpack.json
+++ b/versions/m-/mlpack.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "e0f7e5146cb0e05db15029e44803bac6d3c09a00",
+ "git-tree": "aa79e1e52ba4e3112b84d77bc321580988b945f0",
"version": "3.4.1",
"port-version": 3
},
Ouch, thanks for the fix! |
Describe the pull request
What does your PR fix?
Fixes mlpack build failure #21310Update
supports: uwp
assupports: !uwp
. This is caused by mistake via PR #17983.