Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline] Remove qwt-qt6 due to conflict with qwt. #21825

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

BillyONeal
Copy link
Member

No description provided.

@BillyONeal BillyONeal added the category:port-bug The issue is with a library, which is something the port should already support label Dec 2, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5ddd7f02689b7c5aab78711d77f61db5d2e5e79c -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 741f336..2e84594 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5856,6 +5856,10 @@
       "baseline": "6.2.0",
       "port-version": 1
     },
+    "qwt-qt6": {
+      "baseline": "6.2.0",
+      "port-version": 0
+    },
     "qwtw": {
       "baseline": "3.1.0",
       "port-version": 1

This was referenced Dec 2, 2021
@PhoebeHui
Copy link
Contributor

Looking at the qwt-qt6 and qwt, the only difference is dependency, qwt depends on Qt5, qwt-qt6 depends on Qt6, I think we should avoid to add similar port to vcpkg in future.

@PhoebeHui PhoebeHui self-assigned this Dec 2, 2021
@PhoebeHui PhoebeHui changed the title Remove qwt-qt6 due to conflict with qwt. [vcpkg baseline] Remove qwt-qt6 due to conflict with qwt. Dec 2, 2021
@PhoebeHui PhoebeHui added info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines labels Dec 2, 2021
@PhoebeHui
Copy link
Contributor

@BillyONeal, can you merge this PR?

@BillyONeal BillyONeal merged commit a4a63e7 into microsoft:master Dec 3, 2021
@BillyONeal BillyONeal deleted the remove-qwt-qt6 branch December 3, 2021 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants