Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest setting CMAKE_TOOLCHAIN_FILE in PreLoad.cmake to automatically pick up buildsystems/vcpkg.cmake in CLion in documentation. #22275

Closed
wants to merge 1 commit into from
Closed

Suggest setting CMAKE_TOOLCHAIN_FILE in PreLoad.cmake to automatically pick up buildsystems/vcpkg.cmake in CLion in documentation. #22275

wants to merge 1 commit into from

Conversation

kreuzerkrieg
Copy link
Contributor

Fix CLion documentation which describes possible ways to integrate with vcpkg

@kreuzerkrieg kreuzerkrieg mentioned this pull request Dec 31, 2021
Closed
@JackBoosY JackBoosY self-assigned this Dec 31, 2021
@JackBoosY JackBoosY added the category:documentation To resolve the issue, documentation will need to be updated label Dec 31, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 31, 2021
@BillyONeal
Copy link
Member

I believe we considered and explicitly do not recommend that people do this because it interferes with normal CMake behavior; in particular FORCE is really bad; CMAKE_TOOLCHAIN_FILE is generally a user setting (that's why toolchain files exist in the first place).

@BillyONeal BillyONeal changed the title Fix CLion documentation Suggest setting CMAKE_TOOLCHAIN_FILE in CMakeLists.txt to automatically pick up buildsystems/vcpkg.cmake in documentation. Jan 3, 2022
@BillyONeal BillyONeal added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 3, 2022
@BillyONeal BillyONeal changed the title Suggest setting CMAKE_TOOLCHAIN_FILE in CMakeLists.txt to automatically pick up buildsystems/vcpkg.cmake in documentation. Suggest setting CMAKE_TOOLCHAIN_FILE in PreLoad.cmake to automatically pick up buildsystems/vcpkg.cmake in CLion in documentation. Jan 3, 2022
@strega-nil-ms strega-nil-ms added requires:author-response and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Jan 19, 2022
@JackBoosY
Copy link
Contributor

Ping @kreuzerkrieg for reply.

@kreuzerkrieg
Copy link
Contributor Author

Ping @kreuzerkrieg for reply.

what?
I think @BillyONeal was clear about this PR, just decline it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:documentation To resolve the issue, documentation will need to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kreuzerkrieg @BillyONeal @JackBoosY @strega-nil-ms