Fix QHull port to remove static link libraries when installing dynamic link libraries #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable Ninja build in QHull port.
Fix remove files when install dynamic libraries.
Fix PCL port according to QHull port change. PCL will link dynamic link librariy of QHull when build dynamic link library configure.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, QHull port installs not only dynamic link libraries but also static link libraries even if specify dynamic configure to
VCPKG_LIBRARY_LINKAGE.The pull request will fix this problem of QHull port. In addition, Fix PCL port according to QHull port changes.
(Also, QHull port changed to build with Ninja. It will be a little faster.)