-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Prefer STREQUAL over MATCHES #23014
[vcpkg] Prefer STREQUAL over MATCHES #23014
Conversation
I don't think we're using regex because it's too slow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's full keyword regex. I think that's correct.
These changes are all improvements, but not worth forcing everyone to rebuild the world over, as an edit to However, the changes to |
Sorry, I've just been informed the correct tag is "next-rollup" rather than "world-rebuild"; the latter is about PRs in progress while this PR is otherwise ready-to-merge. |
LGTM, thanks for the improvement! |
Avoid using CMake's well-known slow regex engine if it is not necessary
Used the regex
if.*MATCHES "\^[\w\s]*\$"
to find all occurrences.