Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cl.exe path based architecture detection for CMake toolchain #231

Merged
merged 1 commit into from
Oct 31, 2016

Conversation

kumar8600
Copy link

In CMake use case, I want to use generators NMake Makefiles and Ninja for x64 architecture. But current auto architecture detection result is fixed to x86.

So I Add cl.exe path based architecture detection. This works well because the generators do same thing.

@msftclas
Copy link

Hi @kumar8600, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@ras0219-msft ras0219-msft merged commit 0b54a01 into microsoft:master Oct 31, 2016
ras0219-msft added a commit that referenced this pull request Oct 31, 2016
Add cl.exe path based architecture detection for CMake toolchain
@ras0219-msft
Copy link
Contributor

Thanks, this is an excellent improvement 👍

@kumar8600
Copy link
Author

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants