-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[winsparkle] Intitial commit with binary copy #23194
Conversation
Could you please solve the failure in winsparkle:x64-windows-static and winsparkle:x64-windows-static-md?
|
In this case it is a false positive. Do you have an idea how to silence it? |
set(VCPKG_POLICY_DLLS_IN_STATIC_LIBRARY enabled) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for winsparkle but no changes to version or port version.
-- Version: 0.7.0
-- Old SHA: 3de12a4bb10bb91edb9bb06ce6d089340cd488eb
-- New SHA: 0d756f506e6a79a2a79706f9080c05b45e7df882
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
What does this mean? There are no DLLs? Or there are never static libs? Or a mix is expected?
|
I have now set VCPKG_POLICY_DLLS_IN_STATIC_LIBRARY to disable the false positive error. This port just copied the recompiled DLLs over. There are no static libs by design, because it is desired to update the application and the winsparkle DLL independently. |
This PR adds winsparkle to the ports. This is the alternative solution, copying the prebuild binaries as suggested here:
#17563
Fixes #16607
Which triplets are supported/not supported? Have you updated the CI baseline?
Only windows x64 and x86 targets are supported. Other triplet settings are ignored because this is a binary copy of the recompiled binaries.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes