-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg baseline] Fix ports build on Linux #23478
[vcpkg baseline] Fix ports build on Linux #23478
Conversation
|
|
…jack/vcpkg-baseline-20220310
ports/ncurses/vcpkg.json
Outdated
@@ -1,6 +1,9 @@ | |||
{ | |||
"name": "ncurses", | |||
"version-string": "6.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version-string": "6.3", | |
"version": "6.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BillyONeal The failure of our PR suggestion agent should be due to an incorrect version field in the manifest file, but no specific error message is mentioned in the log:
.\vcpkg.exe x-add-version --overwrite-version ncurses
Use the version scheme "version" instead of "version-string" in port "ncurses".
Use `--skip-version-format-check` to disable this check.
That should caused by the vcpkg-tool changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout e6509c997fef840f7cfdb84cf6e757b70ee283a8 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/n-/ncurses.json b/versions/n-/ncurses.json
index f4b5db2..26698d5 100644
--- a/versions/n-/ncurses.json
+++ b/versions/n-/ncurses.json
@@ -1,8 +1,8 @@
{
"versions": [
{
- "git-tree": "46f36d51c287c33525346dcf6fb903ddeea5a4d7",
- "version-string": "6.3",
+ "git-tree": "ea7aecbf38cef7f64f929c679d55812e679ca496",
+ "version": "6.3",
"port-version": 1
},
{
@BillyONeal @vicroms Please merge this PR first after review. |
That's because this port can only be built as release. Use cmake build system instead.
Related: #23476 #23429