Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline] Fix ports build on Linux #23478

Merged
merged 12 commits into from
Mar 11, 2022

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Mar 10, 2022

  1. Fix ncurses:x64-linux build:
Mismatching number of debug and release binaries. Found 10 for debug but 5 for release.
Debug binaries

    /home/usr/work/vcpkg/packages/ncurses_x64-linux/debug/lib/libpanel_g.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/debug/lib/libncurses++_g.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/debug/lib/libform_g.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/debug/lib/libpanel.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/debug/lib/libncurses++.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/debug/lib/libncurses.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/debug/lib/libmenu_g.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/debug/lib/libform.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/debug/lib/libncurses_g.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/debug/lib/libmenu.a

Release binaries

    /home/usr/work/vcpkg/packages/ncurses_x64-linux/lib/libpanel.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/lib/libncurses++.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/lib/libncurses.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/lib/libform.a
    /home/usr/work/vcpkg/packages/ncurses_x64-linux/lib/libmenu.a
  1. Fix libgnutls:x64-linux build:
In ice-9/boot-9.scm:
   752:25  0 (dispatch-exception _ _ _)

ice-9/boot-9.scm:752:25: In procedure dispatch-exception:
In procedure dynamic-link: file: "/mnt/vcpkg-ci/buildtrees/libgnutls/x64-linux-dbg/guile/src/guile-gnutls-v-2", message: "file not found"
make[3]: *** [Makefile:2520: modules/gnutls.go] Error 1
make[3]: *** Waiting for unfinished jobs....
  1. Fix pcapplusplus:x64-linux build:
Release binaries

    /Users/vagrant/Data/packages/pcapplusplus_x64-osx/lib/libPcap++.a
    /Users/vagrant/Data/packages/pcapplusplus_x64-osx/lib/libCommon++.a
    /Users/vagrant/Data/packages/pcapplusplus_x64-osx/lib/libPacket++.a

Debug binaries were not found

That's because this port can only be built as release. Use cmake build system instead.

Related: #23476 #23429

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 10, 2022
@JackBoosY JackBoosY changed the title [vcpkg baseline] Fix ncurses linux build [vcpkg baseline] Fix ports build on Linux Mar 10, 2022
@Neumann-A
Copy link
Contributor

Building package pcapplusplus[core]:x64-osx...

Release binaries

    /Users/vagrant/Data/packages/pcapplusplus_x64-osx/lib/libPcap++.a
    /Users/vagrant/Data/packages/pcapplusplus_x64-osx/lib/libCommon++.a
    /Users/vagrant/Data/packages/pcapplusplus_x64-osx/lib/libPacket++.a

Debug binaries were not found

Found 1 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile:

@Neumann-A
Copy link
Contributor

-- Performing post-build validation
Mismatching number of debug and release binaries. Found 73 for debug but 74 for release.
Debug binaries

    /mnt/vcpkg-ci/packages/python3_x64-linux/debug/lib/libpython3.10d.a
    /mnt/vcpkg-ci/packages/python3_x64-linux/debug/lib/python3.10/lib-dynload/_codecs_hk.cpython-310d-x86_64-linux-gnu.so
    /mnt/vcpkg-ci/packages/python3_x64-linux/debug/lib/python3.10/lib-dynload/_uuid.cpython-310d-x86_64-linux-gnu.so
    /mnt/vcpkg-ci/packages/python3_x64-linux/debug/lib/python3.10/lib-dynload/xxlimited_35.cpython-310d-x86_64-linux-gnu.so
    /mnt/vcpkg-ci/packages/python3_x64-linux/debug/lib/python3.10/lib-dynload/_sha512.cpython-310d-x86_64-linux-gnu.so
    /mnt/vcpkg-ci/packages/python3_x64-linux/debug/lib/python3.10/lib-dynload/resource.cpython-310d-x86_64-linux-gnu.so
    /mnt/vcpkg-ci/packages/python3_x64-linux/debug/lib/python3.10/lib-dynload/_testinternalcapi.cpython-310d-x86_64-linux-gnu.so

@@ -1,6 +1,9 @@
{
"name": "ncurses",
"version-string": "6.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version-string": "6.3",
"version": "6.3",

Copy link
Contributor Author

@JackBoosY JackBoosY Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillyONeal The failure of our PR suggestion agent should be due to an incorrect version field in the manifest file, but no specific error message is mentioned in the log:

.\vcpkg.exe x-add-version --overwrite-version ncurses
Use the version scheme "version" instead of "version-string" in port "ncurses".
Use `--skip-version-format-check` to disable this check.

That should caused by the vcpkg-tool changes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout e6509c997fef840f7cfdb84cf6e757b70ee283a8 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/n-/ncurses.json b/versions/n-/ncurses.json
index f4b5db2..26698d5 100644
--- a/versions/n-/ncurses.json
+++ b/versions/n-/ncurses.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "46f36d51c287c33525346dcf6fb903ddeea5a4d7",
-      "version-string": "6.3",
+      "git-tree": "ea7aecbf38cef7f64f929c679d55812e679ca496",
+      "version": "6.3",
       "port-version": 1
     },
     {

@JackBoosY
Copy link
Contributor Author

@BillyONeal @vicroms Please merge this PR first after review.

@JackBoosY JackBoosY requested a review from LilyWangLL March 11, 2022 08:13
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Mar 11, 2022
@vicroms vicroms merged commit 03ecabf into microsoft:master Mar 11, 2022
@JackBoosY JackBoosY deleted the dev/jack/vcpkg-baseline-20220310 branch March 14, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New vcpkg version causes ncurses to build additional libraries on x64-linux
4 participants