Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-tool-meson] update meson and see what breaks #23717

Merged
merged 14 commits into from
May 25, 2022

Conversation

Neumann-A
Copy link
Contributor

No description provided.

@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Mar 23, 2022
@PhoebeHui PhoebeHui changed the title update meson and see what breaks [vcpkg-tool-meson] update meson and see what breaks Apr 1, 2022
@JackBoosY
Copy link
Contributor

Any progress in this PR?

@Neumann-A
Copy link
Contributor Author

I don't consider this a priority. If you have time to fix the regression please do so.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 314018fef43c7e3a52a3e46599313b70ace3977a -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index cb04d73..9154819 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7377,8 +7377,8 @@
       "port-version": 0
     },
     "vcpkg-tool-meson": {
-      "baseline": "0.60.2",
-      "port-version": 2
+      "baseline": "0.62.1",
+      "port-version": 0
     },
     "vcpkg-tool-mozbuild": {
       "baseline": "3.3",
diff --git a/versions/v-/vcpkg-tool-meson.json b/versions/v-/vcpkg-tool-meson.json
index c514368..fdec9a2 100644
--- a/versions/v-/vcpkg-tool-meson.json
+++ b/versions/v-/vcpkg-tool-meson.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "fae668bea9fbfcc69c236f8982836fcefc6e8dab",
+      "version": "0.62.1",
+      "port-version": 0
+    },
     {
       "git-tree": "6fe7cf1649af5d90c1e88765411a463cac55e99c",
       "version": "0.60.2",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/vcpkg-tool-meson/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 314018fef43c7e3a52a3e46599313b70ace3977a -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index cb04d73..9154819 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7377,8 +7377,8 @@
       "port-version": 0
     },
     "vcpkg-tool-meson": {
-      "baseline": "0.60.2",
-      "port-version": 2
+      "baseline": "0.62.1",
+      "port-version": 0
     },
     "vcpkg-tool-mozbuild": {
       "baseline": "3.3",
diff --git a/versions/v-/vcpkg-tool-meson.json b/versions/v-/vcpkg-tool-meson.json
index c514368..69bab50 100644
--- a/versions/v-/vcpkg-tool-meson.json
+++ b/versions/v-/vcpkg-tool-meson.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "3ef0eb841cac87372d19e27bfc4ad7c08f3fcee2",
+      "version": "0.62.1",
+      "port-version": 0
+    },
     {
       "git-tree": "6fe7cf1649af5d90c1e88765411a463cac55e99c",
       "version": "0.60.2",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/vcpkg-tool-meson/vcpkg.json

Valid values for the license field can be found in the documentation

@Neumann-A Neumann-A marked this pull request as ready for review May 23, 2022 20:35
@JackBoosY JackBoosY added category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines labels May 24, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you've had a chance to look at my comment. Give me a thumbs up if you're happy with the PR.

ports/vcpkg-tool-meson/vcpkg-port-config.cmake Outdated Show resolved Hide resolved
Neumann-A and others added 2 commits May 25, 2022 08:26
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-tool-meson have changed but the version was not updated
version: 0.62.1
old SHA: 8f68ec003b976139c3d3b9c97531685cd0973354
new SHA: e35f24d912749fa1de06cb3cf533028e6f363398
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@ras0219-msft ras0219-msft merged commit f4de177 into microsoft:master May 25, 2022
@ras0219-msft
Copy link
Contributor

Thanks!

@Neumann-A Neumann-A deleted the update_meson_0.62.0 branch May 26, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants