[openxr-loader] Fix package name and enable arm

[bwrsandman]

Describe the pull request

• What does your PR fix?

Makes it easier to use openxr-loader and enabled arm

Previously it prints this with find_package(openxr-loader which is wrong and should have OpenXR.

[cmake] The package openxr-loader provides CMake targets:
[cmake] 
[cmake]     find_package(openxr-loader CONFIG REQUIRED)
[cmake]     target_link_libraries(main PRIVATE OpenXR::headers OpenXR::openxr_loader)

Now it prints:

[cmake] The package openxr-loader provides CMake targets:
[cmake] 
[cmake]     find_package(OpenXR CONFIG REQUIRED)
[cmake]     target_link_libraries(main PRIVATE OpenXR::headers OpenXR::openxr_loader)

• Which triplets are supported/not supported? Have you updated the CI baseline?

I have removed the arm restriction after testing cross compiling to android and host compiling on linux arm

• Does your PR follow the maintainer guide?

Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/openxr-loader/vcpkg.json

Valid values for the license field can be found in the documentation

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 6fa767aca9474519b737f56fcf0a519023c8ee56 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/o-/openxr-loader.json b/versions/o-/openxr-loader.json
index f56d149..e576bd8 100644
--- a/versions/o-/openxr-loader.json
+++ b/versions/o-/openxr-loader.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "29282b8e08976099dea0e7b8aab03077c0047afd",
+      "git-tree": "4f55db29b61060220d599e61470a0db5e53a595c",
       "version": "1.0.22",
       "port-version": 2
     },

[JonLiu1993]

@bwrsandman ,Thanks for yur pr, I tested the usage on my local machine but failed, This is error log:

1> Command line: "C:\WINDOWS\system32\cmd.exe" /c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2019\ENTERPRISE\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Visual Studio 16 2019" -A Win32  -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\vzhli17\source\repos\test-lib\out\install\x86-Debug" -DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/openxr/vcpkg/scripts/buildsystems/vcpkg.cmake "C:\Users\vzhli17\source\repos\test-lib" 2>&1"
1> Working directory: C:\Users\vzhli17\source\repos\test-lib\out\build\x86-Debug
1> [CMake] -- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19042.
1> [CMake] -- The C compiler identification is MSVC 19.29.30137.0
1> [CMake] -- The CXX compiler identification is MSVC 19.29.30137.0
1> [CMake] -- Detecting C compiler ABI info
1> [CMake] -- Detecting C compiler ABI info - done
1> [CMake] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x86/cl.exe - skipped
1> [CMake] -- Detecting C compile features
1> [CMake] -- Detecting C compile features - done
1> [CMake] -- Detecting CXX compiler ABI info
1> [CMake] -- Detecting CXX compiler ABI info - done
1> [CMake] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x86/cl.exe - skipped
1> [CMake] -- Detecting CXX compile features
1> [CMake] -- Detecting CXX compile features - done
1> [CMake] CMake Error at F:/Feature-test/openxr/vcpkg/scripts/buildsystems/vcpkg.cmake:816 (_find_package):
1> [CMake]   Could not find a package configuration file provided by "openxr_loader"
1> [CMake]   with any of the following names:
1> [CMake] 
1> [CMake]     openxr_loaderConfig.cmake
1> [CMake]     openxr_loader-config.cmake
1> [CMake] 
1> [CMake]   Add the installation prefix of "openxr_loader" to CMAKE_PREFIX_PATH or set
1> [CMake]   "openxr_loader_DIR" to a directory containing one of the above files.  If
1> [CMake]   "openxr_loader" provides a separate development package or SDK, be sure it
1> [CMake]   has been installed.

CMakeLists:

# CMakeList.txt : CMake project for test-lib, include source and define
# project specific logic here.
#
cmake_minimum_required (VERSION 3.8)

project(test)
# Add source to this project's executable.
add_executable (test-lib "test-lib.cpp" "test-lib.h")

# TODO: Add tests and install targets if needed.
find_package(openxr_loader CONFIG REQUIRED)

target_link_libraries(test-lib PRIVATE OpenXR::headers OpenXR::openxr_loader)

[bwrsandman]

I updated it after testing. The find package should be OpenXR. The PR should be updated

[bwrsandman]

Also, I don't see why arm is disallowed since Android ARM is one of the biggest usecases for OpenXR (oculus Quest)

[dg0yt]

The port installs share/openxr-loader/OpenXRConfig.cmake. The filename indicates that the proper package name is OpenXR (case-sensitive!) however the location is not right. It must match the package name (case-insensitive). The easiest fix is adding PACKAGE_NAME OpenXR to vcpkg_cmake_config_fixup.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/openxr-loader/vcpkg.json b/ports/openxr-loader/vcpkg.json
index 9b867d9..6c65bc3 100644
--- a/ports/openxr-loader/vcpkg.json
+++ b/ports/openxr-loader/vcpkg.json
@@ -5,7 +5,7 @@
   "description": "A royalty-free, open standard that provides high-performance access to Augmented Reality (AR) and Virtual Reality (VR)—collectively known as XR—platforms and devices",
   "homepage": "https://github.com/KhronosGroup/OpenXR-SDK",
   "license": "Apache-2.0",
-  "supports": "android|!(arm | uwp)",
+  "supports": "android | !(arm | uwp)",
   "dependencies": [
     "jsoncpp",
     {

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout e79aaaaf3c1b157d29388951b5aa2672defc78b8 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/o-/openxr-loader.json b/versions/o-/openxr-loader.json
index 87bca6b..8e59894 100644
--- a/versions/o-/openxr-loader.json
+++ b/versions/o-/openxr-loader.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "9492018923238cff2976b1399f171817f80968a3",
+      "git-tree": "8d0ca56cad6ab2877b6d43ffe30dda20519d9091",
       "version": "1.0.22",
       "port-version": 2
     },

[bwrsandman]

@dg0yt I changed the package name with vcpkg_cmake_config_fixup as you recommended

I also went and enabled arm after testing cross compiling to android armeabi-v7a and testing a host build on ARM linux (raspberry pi).
Still haven't tested arm windows.

One thing of note is that on linux it requires host to have Xlib.h like sdl2[xlib]

[bwrsandman]

I am also pretty sure OpenXR supports uwp for hololens. I don't have the means to test it though

[JonLiu1993]

I tested the usage successfully:

1> CMake generation started for configuration: 'x64-Debug'.
1> Command line: "C:\WINDOWS\system32\cmd.exe" /c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && 
...
...
1> [CMake] -- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19042.
1> [CMake] -- The C compiler identification is MSVC 19.29.30137.0
1> [CMake] -- The CXX compiler identification is MSVC 19.29.30137.0
1> [CMake] -- Detecting C compiler ABI info
1> [CMake] -- Detecting C compiler ABI info - done
1> [CMake] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
1> [CMake] -- Detecting C compile features
1> [CMake] -- Detecting C compile features - done
1> [CMake] -- Detecting CXX compiler ABI info
1> [CMake] -- Detecting CXX compiler ABI info - done
1> [CMake] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
1> [CMake] -- Detecting CXX compile features
1> [CMake] -- Detecting CXX compile features - done
1> [CMake] -- Looking for pthread.h
1> [CMake] -- Looking for pthread.h - not found
1> [CMake] -- Found Threads: TRUE  
1> [CMake] -- Configuring done
1> [CMake] -- Generating done
1> [CMake] -- Build files have been written to: C:/Users/test/source/repos/opex/out/build/x64-Debug
1> Extracted CMake variables.
1> Extracted source files and headers.
1> Extracted code model.
1> Extracted toolchain configurations.
1> Extracted includes paths.
1> CMake generation finished.

[strega-nil-ms]

Thanks!