[harfbuzz] Update to 4.2.0 #24144

bold84 · 2022-04-14T13:00:50Z

Describe the pull request

What does your PR fix?

Fixes #...
Which triplets are supported/not supported? Have you updated the CI baseline?

all
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/harfbuzz/vcpkg.json

Valid values for the license field can be found in the documentation

ports/harfbuzz/vcpkg.json

JonLiu1993 · 2022-04-15T01:57:47Z

It looks like ci fails the test on triples x64-windows-static and x64-windows-static-md , you can get the error log as suggested in the image below:
https://dev.azure.com/vcpkg/public/_build/results?buildId=70674&view=artifacts&pathAsName=false&type=publishedArtifacts

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 99346bb6926e85d93e4aad330bf28cce4a18051b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 9f5739a..cffe65d 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2722,7 +2722,7 @@
     },
     "harfbuzz": {
       "baseline": "4.2.0",
-      "port-version": 3
+      "port-version": 0
     },
     "hayai": {
       "baseline": "2019-08-10",
diff --git a/versions/h-/harfbuzz.json b/versions/h-/harfbuzz.json
index b318da4..0444e35 100644
--- a/versions/h-/harfbuzz.json
+++ b/versions/h-/harfbuzz.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "75697d7c43494eeb0699d372f41853cc937f7a78",
+      "version-semver": "4.2.0",
+      "port-version": 0
+    },
     {
       "git-tree": "a36602c632157bbf3260c196a90172c61e8f859b",
       "version-semver": "4.2.0",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/harfbuzz/vcpkg.json

Valid values for the license field can be found in the documentation

bold84 · 2022-04-15T11:12:44Z

Okay, I see... other ports (aubio, opencv4, pangolin) that depend on harfbuzz fail to build.
I realized now that I actually don't need the harfbuzz update.... But I started already. I hope it's not going to end in dependency hell. Haha..

So, similar to the gn,skia,* ports, I can add them all in one PR, right?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5d66a98f64188bbd806b8e62e66c097d90eb3224 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 9f5739a..cffe65d 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2722,7 +2722,7 @@
     },
     "harfbuzz": {
       "baseline": "4.2.0",
-      "port-version": 3
+      "port-version": 0
     },
     "hayai": {
       "baseline": "2019-08-10",
diff --git a/versions/h-/harfbuzz.json b/versions/h-/harfbuzz.json
index b318da4..0444e35 100644
--- a/versions/h-/harfbuzz.json
+++ b/versions/h-/harfbuzz.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "75697d7c43494eeb0699d372f41853cc937f7a78",
+      "version-semver": "4.2.0",
+      "port-version": 0
+    },
     {
       "git-tree": "a36602c632157bbf3260c196a90172c61e8f859b",
       "version-semver": "4.2.0",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/harfbuzz/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/harfbuzz/vcpkg.json

Valid values for the license field can be found in the documentation

bold84 · 2022-04-15T14:58:40Z

I can not reproduce these errors 😐

dg0yt · 2022-04-15T15:20:45Z

For pangolin:x64-windows-static:

CMake Error at D:/installed/x64-windows-static/share/ffmpeg/FindFFMPEG.cmake:68 (find_library):
  Could not find
  FFMPEG_DEPENDENCY_/d/installed/x64-windows-static/lib/pkgconfig/../../lib/freetype_RELEASE
  using the following names:
  /d/installed/x64-windows-static/lib/pkgconfig/../../lib/freetype
Call Stack (most recent call first):
  D:/installed/x64-windows-static/share/ffmpeg/FindFFMPEG.cmake:148 (append_dependencies)
  D:/installed/x64-windows-static/share/ffmpeg/vcpkg-cmake-wrapper.cmake:6 (_find_package)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:770 (include)
  src/CMakeLists.txt:388 (find_package)

This looks like a path (/d/installed/x64-windows-static/lib/pkgconfig/../../lib/freetype) is used where a plain name (e.g. harfbuzz) is expected. Perhaps wrong export in lib/pkgconfig?

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/harfbuzz/vcpkg.json

Valid values for the license field can be found in the documentation

bold84 · 2022-04-17T16:01:32Z

For pangolin:x64-windows-static:

CMake Error at D:/installed/x64-windows-static/share/ffmpeg/FindFFMPEG.cmake:68 (find_library):
  Could not find
  FFMPEG_DEPENDENCY_/d/installed/x64-windows-static/lib/pkgconfig/../../lib/freetype_RELEASE
  using the following names:
  /d/installed/x64-windows-static/lib/pkgconfig/../../lib/freetype
Call Stack (most recent call first):
  D:/installed/x64-windows-static/share/ffmpeg/FindFFMPEG.cmake:148 (append_dependencies)
  D:/installed/x64-windows-static/share/ffmpeg/vcpkg-cmake-wrapper.cmake:6 (_find_package)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:770 (include)
  src/CMakeLists.txt:388 (find_package)

This looks like a path (/d/installed/x64-windows-static/lib/pkgconfig/../../lib/freetype) is used where a plain name (e.g. harfbuzz) is expected. Perhaps wrong export in lib/pkgconfig?

I still can't reproduce the problem. I started off with a virgin vcpkg clone.

dg0yt · 2022-04-17T20:08:09Z

I still can't reproduce the problem. I started off with a virgin vcpkg clone.

You may not build the same feature configuation as CI does, for ports in the dependency chains. ffmpeg burns some wrong/unexpected data into share/ffmpeg. You probably need ./vcpk install pangolin[ffmpeg] ffmpeg[freetype,ass]. Feature ass pulls harfbuzz via libass into ffmpeg. So in this chain, the harfbuzz update could impact fffmpeg output to share/ffmpeg, which blows up when used by pangolin[ffmpeg].

bold84 · 2022-04-17T22:50:10Z

I still can't reproduce the problem. I started off with a virgin vcpkg clone.

You may not build the same feature configuation as CI does, for ports in the dependency chains. ffmpeg burns some wrong/unexpected data into share/ffmpeg. You probably need ./vcpk install pangolin[ffmpeg] ffmpeg[freetype,ass]. Feature ass pulls harfbuzz via libass into ffmpeg. So in this chain, the harfbuzz update could impact fffmpeg output to share/ffmpeg, which blows up when used by pangolin[ffmpeg].

That makes sense...

bold84 · 2022-04-17T23:24:53Z

Nope...

bold84 · 2022-04-18T22:42:40Z

I still can't reproduce the problem. I started off with a virgin vcpkg clone.

You may not build the same feature configuation as CI does, for ports in the dependency chains. ffmpeg burns some wrong/unexpected data into share/ffmpeg. You probably need ./vcpk install pangolin[ffmpeg] ffmpeg[freetype,ass]. Feature ass pulls harfbuzz via libass into ffmpeg. So in this chain, the harfbuzz update could impact fffmpeg output to share/ffmpeg, which blows up when used by pangolin[ffmpeg].

That makes sense...

Okay... I figured out that I can run

.\vcpkg.exe ci --triplet=x64-windows-static

So, let's see...

dg0yt · 2022-04-19T03:55:38Z

Maybe you lack the overlay ports in scripts/test-ports. They pull in additional features.

bold84 · 2022-04-19T05:21:47Z

Maybe you lack the overlay ports in scripts/test-ports. They pull in additional features.

Thank you. I already started one build a few hours ago. 1871 packages.
I will see if the problem occurs. If the issue doesn't occur, I will add the overlay ports, as you suggested.

dg0yt · 2022-04-19T05:41:19Z

If you restart the CI build, you may also want to add skipped ports, based on ci.baseline.txt and manual additions. In particular, you proabably want to skip tensorflow.

dg0yt · 2022-04-19T05:46:15Z

Other hints to mitigate vcpkg ci build time:

use parent hashes. (vcpkg ci --dry-run --export-hashes for a parent commit to get these hashes.) Removes unaffected ports from the build, as in vcpkg PR CI.
Let vcpkg's PR do the work, but add a message(FATAL_ERROR STOP) at the end of the ports you need to examine. For example, copy relevant config files to the port's log directory before the stop, so that they are included in the failure logs.

# Conflicts: # ports/harfbuzz/portfile.cmake # ports/harfbuzz/vcpkg.json # versions/baseline.json # versions/h-/harfbuzz.json

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for harfbuzz but no changes to version or port version.
-- Version: 4.2.0
-- Old SHA: 1f02c7e1133785d12121cf295009465706cc5dd7
-- New SHA: 62b08c05899c0e8eefcf5880d1e9f8336a284e26
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

bold84 · 2022-04-23T12:58:18Z

In was able to reproduce this problem. The .pc file provided by harfbuzz 4.2.0 contains absolute paths to the libraries it depends on.

I assume that's because installation directory (packages) differs from the directory the dependencies are installed to.

The FindFFMPEG.cmake file can't handle paths. It expects the library names.

There are several ways to solve this problem. Currently, I intend to solve it in vcpkg_fixup_pkgconfig.cmake, as I expect this problem to occur with other ports in the future (if the projects switch to meson, which seems to be in fashion).

What do you think?

dg0yt · 2022-04-23T15:22:33Z

Changing vcpkg_fixup_pkgconfig.cmake will trigger the next world rebuild (> 10h, cf. #23898).
And vcpkg_fixup_pkgconfig.cmake already does a lot to avoid absolute paths.
So better make add a minimal local fixup (patch, or explicit replacement) in port harfbuzz now, unless you have evidence of a common pattern.

bold84 · 2022-04-23T16:02:45Z

Thank you for your response, @dg0yt .

I'm aware of that.
I wouldn't mess things up the way I did with vcpkg-tool-gn again. 😂
Now, I have the resources and knowledge to build locally in the same way as the CI does (the parts I need).

But I think you're right. Let's see if it happens again with other ports.
So, I will solve the problem for this particular case in the port files.

…ws static build\nRemoved patches

JonLiu1993 · 2022-04-25T06:37:08Z

@bold84 , Thanks for your pr, if this pr is ready for review, please let me know

bold84 · 2022-04-25T07:27:57Z

@JonLiu1993 Ready :-)

ports/harfbuzz/vcpkg.json

JonLiu1993 · 2022-04-27T06:15:14Z

All features are tested successfully in the following triplet:

x64-windows
x64-windows-static

BillyONeal · 2022-04-28T22:32:09Z

Thanks for the update!

bold84 added 2 commits April 14, 2022 19:56

updated harfbuzz from 3.2.0 to 4.2.0

6ff4641

updated version

2a2fe92

github-actions bot approved these changes Apr 14, 2022

View reviewed changes

JonLiu1993 self-assigned this Apr 15, 2022

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 15, 2022

JonLiu1993 reviewed Apr 15, 2022

View reviewed changes

ports/harfbuzz/vcpkg.json Outdated Show resolved Hide resolved

JonLiu1993 added the requires:author-response label Apr 15, 2022

Update ports/harfbuzz/vcpkg.json

0ca5352

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions bot requested changes Apr 15, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master' into update_harfbuzz

18e547b

github-actions bot requested changes Apr 15, 2022

View reviewed changes

updated version

d4b7d43

github-actions bot approved these changes Apr 15, 2022

View reviewed changes

bold84 marked this pull request as draft April 15, 2022 14:27

Merge remote-tracking branch 'origin/master' into update_harfbuzz

3a49d73

github-actions bot approved these changes Apr 17, 2022

View reviewed changes

JonLiu1993 removed the requires:author-response label Apr 18, 2022

Merge remote-tracking branch 'origin/master' into update_harfbuzz

2dfa1e6

# Conflicts: # ports/harfbuzz/portfile.cmake # ports/harfbuzz/vcpkg.json # versions/baseline.json # versions/h-/harfbuzz.json

github-actions bot approved these changes Apr 22, 2022

View reviewed changes

github-actions bot requested changes Apr 22, 2022

View reviewed changes

bold84 force-pushed the update_harfbuzz branch from 0f48e4d to f18b1ba Compare April 22, 2022 09:40

github-actions bot approved these changes Apr 22, 2022

View reviewed changes

github-actions bot approved these changes Apr 24, 2022

View reviewed changes

Removed paths from library definitions in *.pc files in case of windo…

ecdf9ef

…ws static build\nRemoved patches

bold84 force-pushed the update_harfbuzz branch from e7c50c0 to ecdf9ef Compare April 24, 2022 13:52

github-actions bot approved these changes Apr 24, 2022

View reviewed changes

bold84 marked this pull request as ready for review April 25, 2022 07:27

JonLiu1993 reviewed Apr 25, 2022

View reviewed changes

ports/harfbuzz/vcpkg.json Outdated Show resolved Hide resolved

JonLiu1993 added the requires:author-response label Apr 25, 2022

version-semver -> version

0d5832f

github-actions bot approved these changes Apr 26, 2022

View reviewed changes

JonLiu1993 removed the requires:author-response label Apr 27, 2022

JonLiu1993 approved these changes Apr 27, 2022

View reviewed changes

JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 27, 2022

Merge remote-tracking branch 'origin/master' into HEAD

9efd03d

BillyONeal approved these changes Apr 28, 2022

View reviewed changes

github-actions bot approved these changes Apr 28, 2022

View reviewed changes

Delete no longer applied patches.

4e1b578

BillyONeal merged commit 0d71120 into microsoft:master Apr 28, 2022

bold84 deleted the update_harfbuzz branch April 29, 2022 01:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[harfbuzz] Update to 4.2.0 #24144

[harfbuzz] Update to 4.2.0 #24144

bold84 commented Apr 14, 2022

github-actions bot left a comment

JonLiu1993 commented Apr 15, 2022

github-actions bot left a comment

bold84 commented Apr 15, 2022

github-actions bot left a comment

github-actions bot left a comment

bold84 commented Apr 15, 2022

dg0yt commented Apr 15, 2022 •

edited

Loading

github-actions bot left a comment

bold84 commented Apr 17, 2022 •

edited

Loading

dg0yt commented Apr 17, 2022

bold84 commented Apr 17, 2022

bold84 commented Apr 17, 2022

bold84 commented Apr 18, 2022

dg0yt commented Apr 19, 2022

bold84 commented Apr 19, 2022 •

edited

Loading

dg0yt commented Apr 19, 2022

dg0yt commented Apr 19, 2022

github-actions bot left a comment

bold84 commented Apr 23, 2022 •

edited

Loading

dg0yt commented Apr 23, 2022

bold84 commented Apr 23, 2022 •

edited

Loading

JonLiu1993 commented Apr 25, 2022

bold84 commented Apr 25, 2022

JonLiu1993 commented Apr 27, 2022

BillyONeal commented Apr 28, 2022

[harfbuzz] Update to 4.2.0 #24144

[harfbuzz] Update to 4.2.0 #24144

Conversation

bold84 commented Apr 14, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Apr 15, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

bold84 commented Apr 15, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

bold84 commented Apr 15, 2022

dg0yt commented Apr 15, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

bold84 commented Apr 17, 2022 • edited Loading

dg0yt commented Apr 17, 2022

bold84 commented Apr 17, 2022

bold84 commented Apr 17, 2022

bold84 commented Apr 18, 2022

dg0yt commented Apr 19, 2022

bold84 commented Apr 19, 2022 • edited Loading

dg0yt commented Apr 19, 2022

dg0yt commented Apr 19, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

bold84 commented Apr 23, 2022 • edited Loading

dg0yt commented Apr 23, 2022

bold84 commented Apr 23, 2022 • edited Loading

JonLiu1993 commented Apr 25, 2022

bold84 commented Apr 25, 2022

JonLiu1993 commented Apr 27, 2022

BillyONeal commented Apr 28, 2022

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

dg0yt commented Apr 15, 2022 •

edited

Loading

bold84 commented Apr 17, 2022 •

edited

Loading

bold84 commented Apr 19, 2022 •

edited

Loading

bold84 commented Apr 23, 2022 •

edited

Loading

bold84 commented Apr 23, 2022 •

edited

Loading