[blas/lapack] force vendor #24327
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| prefix=${pcfiledir}/../.. | ||
|
|
||
| Name: BLAS | ||
| Description: Implementation of BLAS | ||
| Version: | ||
| Requires: @requires@ | ||
| Libs: @libs@ | ||
| Cflags: @cflags@ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,46 @@ | ||
| SET(VCPKG_POLICY_EMPTY_PACKAGE enabled) | ||
|
|
||
| file(READ "${CURRENT_PORT_DIR}/vcpkg.json" manifest_contents) | ||
| string(JSON ver_str GET "${manifest_contents}" version-string) | ||
|
|
||
| if(ver_str STREQUAL "default") | ||
|
There was a problem hiding this comment. Is this leftover from an experiment? There was a problem hiding this comment. The idea is to also supply the version-strings "blas-reference|netlib-blas","openblas" (so every platform uses openblas) and "mkl" to determine the selection in the future (since the options RFC is seemingly going nowhere in the near future. But if it comes it would just replace the existing |
||
| # OpenBLAS | ||
| if(VCPKG_TARGET_IS_OSX) | ||
| set(BLA_VENDOR Apple) | ||
| set(requires "") | ||
| set(libs "-framework Accelerate") | ||
| set(cflags "-framework Accelerate") | ||
| elseif(VCPKG_TARGET_IS_WINDOWS AND VCPKG_LIBRARY_LINKAGE STREQUAL "static") | ||
| set(BLA_VENDOR Generic) | ||
| set(requires "blas-reference") | ||
| else() | ||
| set(BLA_VENDOR OpenBLAS) | ||
| set(requires openblas) | ||
| endif() | ||
|
|
||
| configure_file("${CMAKE_CURRENT_LIST_DIR}/blas.pc.in" "${CURRENT_PACKAGES_DIR}/lib/pkgconfig/blas.pc" @ONLY) | ||
| if(NOT VCPKG_BUILD_TYPE) | ||
| configure_file("${CMAKE_CURRENT_LIST_DIR}/blas.pc.in" "${CURRENT_PACKAGES_DIR}/debug/lib/pkgconfig/blas.pc" @ONLY) | ||
| endif() | ||
| # For possible overlays: | ||
|
|
||
| # Intel MKL | ||
| #if(VCPKG_TARGET_ARCHITECTURE STREQUAL x64) | ||
| # set(BLA_VENDOR Intel10_64lp) | ||
| #elseif(VCPKG_TARGET_ARCHITECTURE STREQUAL x86) | ||
| # set(BLA_VENDOR Intel10_32) | ||
| #else() | ||
| # message(FATAL_ERROR "Unsupported target architecture for Intel MKL!") | ||
| #endif() | ||
|
|
||
| # Apple Accelerate Framework | ||
| # set(BLA_VENDOR Apple) | ||
|
|
||
| if(VCPKG_LIBRARY_LINKAGE STREQUAL "static") | ||
| set(BLA_STATIC ON) | ||
| else() | ||
| set(BLA_STATIC OFF) | ||
| endif() | ||
|
|
||
| configure_file("${CMAKE_CURRENT_LIST_DIR}/vcpkg-cmake-wrapper.cmake.in" "${CURRENT_PACKAGES_DIR}/share/blas/vcpkg-cmake-wrapper.cmake" @ONLY) | ||
| endif() | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| set(BLA_VENDOR @BLA_VENDOR@) | ||
| set(BLA_STATIC @BLA_STATIC@) | ||
| _find_package(${ARGS}) | ||
| unset(BLA_VENDOR) | ||
| unset(BLA_STATIC) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,22 @@ | ||
| { | ||
| "$comment": "Keep the platform expressions in sync with the wrappers installed by the portfiles!", | ||
| "name": "blas", | ||
| "version-string": "default", | ||
| "description": "Metapackage for packages which provide BLAS", | ||
| "license": null, | ||
| "dependencies": [ | ||
| { | ||
| "$comment": "Will use internal generic BLAS of lapack-reference", | ||
| "name": "lapack-reference", | ||
| "platform": "static & windows" | ||
| }, | ||
| { | ||
| "name": "openblas", | ||
| "platform": "!(osx | (static & windows))" | ||
| }, | ||
| { | ||
| "name": "vcpkg-cmake", | ||
| "host": true | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove
PACKAGE_NAME Armadillo? It creates inconsistencies depending on filesystem case-sensitivity, and the default is good enough here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I try to keep upstream case convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we care for upstream, we should leave the config in share/Armadillo/CMake...
Do you see share/Armadillo when vcpkg creates share/${PORT} first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will
vcpkg_cmake_config_fixupfixup the case in the include below? If not -> Never mess with upstream case you are just asking for includes not being found ;)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even the do-not-mess-with-directory-name policy could be handled for omitting
PACKAGE_NAME...From a strict point of view, vcpkg shouldn't move config out of any location which is fully supported by CMake.
But given that the include is already treated with
vcpkg_replace_string, it would be easy to handle this particular case.