[world rebuild|toolchain] Fix try compile handling #24493

Neumann-A · 2022-05-01T08:15:43Z

while playing with qtbase on x64-uwp i found that it could not pass a try_compile command since important variables are not correctly forwarded. As such I concluded that the handling of try_compile in vcpkg is completely wrong.

(just learned qt6 does not support uwp. Nevertheless fixing try_compile is still and issue. )

BillyONeal · 2022-05-01T23:24:49Z

/azp run

azure-pipelines · 2022-05-01T23:24:57Z

Azure Pipelines successfully started running 1 pipeline(s).

scripts/buildsystems/vcpkg.cmake

scripts/toolchains/uwp.cmake

scripts/buildsystems/vcpkg.cmake

…into fix_try_compile # Conflicts: # scripts/buildsystems/vcpkg.cmake

scripts/buildsystems/vcpkg.cmake

Cheney-W · 2022-05-05T09:50:00Z

@ras0219-msft Could you please help review this PR?

Cheney-W · 2022-06-17T08:56:12Z

Tagged reviewed so other members will review this changes (doesn't means approved).

Neumann-A · 2024-06-01T15:07:43Z

@JavierMatosD @BillyONeal @vicroms: I feel like this PR got forgotten which is why i ping.

BillyONeal · 2024-06-13T00:42:07Z

This seems reasonable to me. I'm not sure how to verify that it is correct though. Can you show what a before/after of this change would imply?

I realize it's been a long time :)

BillyONeal · 2024-06-13T00:47:41Z

scripts/toolchains/windows.cmake

+    if(POLICY CMP0056)
+        cmake_policy(SET CMP0056 NEW)
+    endif()
+    if(POLICY CMP0066)
+        cmake_policy(SET CMP0066 NEW)
+    endif()
+    if(POLICY CMP0067)
+        cmake_policy(SET CMP0067 NEW)
+    endif()
+    if(POLICY CMP0137)
+        cmake_policy(SET CMP0137 NEW)
+    endif()
+    list(APPEND CMAKE_TRY_COMPILE_PLATFORM_VARIABLES
+       VCPKG_CRT_LINKAGE VCPKG_TARGET_ARCHITECTURE VCPKG_SET_CHARSET_FLAG
+       VCPKG_C_FLAGS VCPKG_CXX_FLAGS
+       VCPKG_C_FLAGS_DEBUG VCPKG_CXX_FLAGS_DEBUG
+       VCPKG_C_FLAGS_RELEASE VCPKG_CXX_FLAGS_RELEASE
+       VCPKG_LINKER_FLAGS VCPKG_LINKER_FLAGS_RELEASE VCPKG_LINKER_FLAGS_DEBUG
+       VCPKG_PLATFORM_TOOLSET
+    )


This is the part that seems like the 'meat' of the change, and the rest seems like style changes. Does this need to be applied to xbox too?

I was planning to revisit the xbox triplets when this was finished. Is it ready for that?

I think this was in a perpetual circle waiting for @ras0219-msft to look at it because none of the other maintainers feel confident in vouching for the correctness of the change. In retrospect a specific test case of "this should work and does not" might have gone a long way to it not waiting like this for 2 years.

I'm not confident in the correctness either, but I'm willing to believe it did fix some problem for @Neumann-A , and I didn't see anything here that's obviously incorrect (why would passing more variables to try_compile be bad?)

The meat of the change is the removal of:

get_property( _CMAKE_IN_TRY_COMPILE GLOBAL PROPERTY IN_TRY_COMPILE ) if(NOT _CMAKE_IN_TRY_COMPILE)

The changes of CMAKE_TRY_COMPILE_PLATFORM_VARIABLES is just a result of that since the FLAGS being set in the if block require those variables to exist.
you can look into https://github.com/user-attachments/files/15814754/diff.txt to see what exactly did change due to that. removal and the adding of the VCPKG_ variables to CMAKE_TRY_COMPILE_PLATFORM_VARIABLES.

Neumann-A · 2024-06-13T06:23:23Z

Can you show what a before/after of this change would imply?

Test case added in 7bcc75a. Port fails in current master.

Here is the diff of the CMakeCache generated for the try_compile command:
diff.txt

dg0yt · 2024-06-13T06:29:38Z

Here is the diff of the CMakeCache generated for the try_compile command:

-//Flags used by the CXX compiler during RELEASE builds.
-CMAKE_CXX_FLAGS_RELEASE:STRING=/MD /O2 /Ob2 /DNDEBUG
+CMAKE_CXX_FLAGS_RELEASE:STRING='/MD /O2 /Oi /Gy /DNDEBUG /Z7 '

Shouldn't we be concerned about the extra '?

Neumann-A · 2024-06-13T06:33:44Z

Shouldn't we be concerned about the extra '?

That is CMake automagically doing it. I assume it is due to the additional space at the end of the flags. Since flags without that space don't have the extra '

Neumann-A · 2024-06-18T17:45:30Z

@BillyONeal arm windows CI hanging building GTK3 here?

BillyONeal · 2024-06-18T18:57:16Z

@BillyONeal arm windows CI hanging building GTK3 here?

Yeah, I kicked it by pushing a merge

dg0yt · 2024-06-19T05:23:19Z

@BillyONeal arm windows CI hanging building GTK3 here?

Remember #32327. Would have supplied logs. Might have enabled a fix.

BillyONeal · 2024-06-19T21:38:48Z

Thanks for the fix and sorry you were in a holding pattern for 2 years

walbourn · 2024-06-21T03:18:38Z

OK, so once I remove the property test and add the other elements to xbox.cmake that are in windows.cmake, how do I verify this is working as intended?

BillyONeal · 2024-06-22T02:23:09Z

@walbourn

OK, so once I remove the property test and add the other elements to xbox.cmake that are in windows.cmake, how do I verify this is working as intended?

You can run the test port from this PR:

PS D:\vcpkg> .\vcpkg.exe install try-compile:x64-windows --overlay-ports scripts\test_ports --enforce-port-checks
Computing installation plan...
The following packages will be built and installed:
    try-compile:x64-windows@1 -- D:\vcpkg\scripts\test_ports\try-compile
Detecting compiler hash for triplet x64-windows...
Compiler found: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.40.33807/bin/Hostx64/x64/cl.exe
Restored 0 package(s) from C:\Users\bion\AppData\Local\vcpkg\archives in 245 us. Use --debug to see more details.
Installing 1/1 try-compile:x64-windows@1...
Building try-compile:x64-windows@1...
D:\vcpkg\scripts\test_ports\try-compile: info: installing overlay port from here
-- Configuring x64-windows
-- Skipping post-build validation due to VCPKG_POLICY_EMPTY_PACKAGE
Stored binaries in 1 destinations in 22.6 ms.
Elapsed time to handle try-compile:x64-windows: 1.6 s
try-compile:x64-windows package ABI: f0f78eaa272af4799922a190f78bc5bcdb8d2396051fb83abbefe0c3b8989f8f
Total install time: 1.6 s
PS D:\vcpkg> .\vcpkg.exe install try-compile:x64-xbox-scarlett --overlay-ports scripts\test_ports --enforce-port-checks
Computing installation plan...
The following packages will be built and installed:
    try-compile:x64-xbox-scarlett@1 -- D:\vcpkg\scripts\test_ports\try-compile
Detecting compiler hash for triplet x64-xbox-scarlett...
Compiler found: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.40.33807/bin/Hostx64/x64/cl.exe
Restored 0 package(s) from C:\Users\bion\AppData\Local\vcpkg\archives in 217 us. Use --debug to see more details.
Installing 1/1 try-compile:x64-xbox-scarlett@1...
Building try-compile:x64-xbox-scarlett@1...
D:\vcpkg\triplets\community\x64-xbox-scarlett.cmake: info: loaded community triplet from here. Community triplets are not built in the curated registry and are thus less likely to succeed.
D:\vcpkg\scripts\test_ports\try-compile: info: installing overlay port from here
-- Configuring x64-xbox-scarlett
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: D:/vcpkg-downloads/tools/ninja/1.10.2-windows/ninja.exe -v
    Working Directory: D:/vcpkg/buildtrees/try-compile/x64-xbox-scarlett-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      D:\vcpkg\buildtrees\try-compile\config-x64-xbox-scarlett-dbg-CMakeCache.txt.log
      D:\vcpkg\buildtrees\try-compile\config-x64-xbox-scarlett-rel-CMakeCache.txt.log
      D:\vcpkg\buildtrees\try-compile\config-x64-xbox-scarlett-dbg-CMakeConfigureLog.yaml.log
      D:\vcpkg\buildtrees\try-compile\config-x64-xbox-scarlett-rel-CMakeConfigureLog.yaml.log
      D:\vcpkg\buildtrees\try-compile\config-x64-xbox-scarlett-out.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:269 (vcpkg_execute_required_process)
  scripts/test_ports/try-compile/portfile.cmake:5 (vcpkg_cmake_configure)
  scripts/ports.cmake:191 (include)


error: building try-compile:x64-xbox-scarlett failed with: BUILD_FAILED
Elapsed time to handle try-compile:x64-xbox-scarlett: 1.1 s
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+try-compile
You can submit a new issue at:
  https://github.com/microsoft/vcpkg/issues/new?title=[try-compile]+Build+error+on+x64-xbox-scarlett&body=Copy+issue+body+from+D%3A%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md

PS D:\vcpkg>

D:\vcpkg\buildtrees\try-compile\config-x64-xbox-scarlett-out.log says:

[1/2] "C:/Program Files/CMake/bin/cmake.exe" -E chdir ".." "C:/Program Files/CMake/bin/cmake.exe" "D:/vcpkg/scripts/test_ports/try-compile" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=D:/vcpkg/packages/try-compile_x64-xbox-scarlett" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DCMAKE_MAKE_PROGRAM=D:/vcpkg-downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DXBOX_CONSOLE_TARGET=scarlett" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=D:/vcpkg/scripts/toolchains/xbox.cmake" "-DVCPKG_TARGET_TRIPLET=x64-xbox-scarlett" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v143" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=D:/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS= -DVCPKG_LET_ME_PASS" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS= -DVCPKG_LET_ME_PASS" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=D:/vcpkg" "-D_VCPKG_INSTALLED_DIR=D:/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF"
FAILED: ../CMakeCache.txt 
"C:/Program Files/CMake/bin/cmake.exe" -E chdir ".." "C:/Program Files/CMake/bin/cmake.exe" "D:/vcpkg/scripts/test_ports/try-compile" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=D:/vcpkg/packages/try-compile_x64-xbox-scarlett" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DCMAKE_MAKE_PROGRAM=D:/vcpkg-downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DXBOX_CONSOLE_TARGET=scarlett" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=D:/vcpkg/scripts/toolchains/xbox.cmake" "-DVCPKG_TARGET_TRIPLET=x64-xbox-scarlett" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v143" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=D:/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS= -DVCPKG_LET_ME_PASS" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS= -DVCPKG_LET_ME_PASS" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=D:/vcpkg" "-D_VCPKG_INSTALLED_DIR=D:/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF"
-- The C compiler identification is MSVC 19.40.33811.0
-- The CXX compiler identification is MSVC 19.40.33811.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.40.33807/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.40.33807/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:8 (message):
  Compiler flags are not passed consistently to try_compile!


-- Configuring incomplete, errors occurred!
[2/2] "C:/Program Files/CMake/bin/cmake.exe" -E chdir "../../x64-xbox-scarlett-dbg" "C:/Program Files/CMake/bin/cmake.exe" "D:/vcpkg/scripts/test_ports/try-compile" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=D:/vcpkg/packages/try-compile_x64-xbox-scarlett/debug" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DCMAKE_MAKE_PROGRAM=D:/vcpkg-downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DXBOX_CONSOLE_TARGET=scarlett" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=D:/vcpkg/scripts/toolchains/xbox.cmake" "-DVCPKG_TARGET_TRIPLET=x64-xbox-scarlett" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v143" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=D:/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS= -DVCPKG_LET_ME_PASS" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS= -DVCPKG_LET_ME_PASS" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=D:/vcpkg" "-D_VCPKG_INSTALLED_DIR=D:/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF"
FAILED: ../../x64-xbox-scarlett-dbg/CMakeCache.txt 
"C:/Program Files/CMake/bin/cmake.exe" -E chdir "../../x64-xbox-scarlett-dbg" "C:/Program Files/CMake/bin/cmake.exe" "D:/vcpkg/scripts/test_ports/try-compile" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=D:/vcpkg/packages/try-compile_x64-xbox-scarlett/debug" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DCMAKE_MAKE_PROGRAM=D:/vcpkg-downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DXBOX_CONSOLE_TARGET=scarlett" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=D:/vcpkg/scripts/toolchains/xbox.cmake" "-DVCPKG_TARGET_TRIPLET=x64-xbox-scarlett" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v143" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=D:/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS= -DVCPKG_LET_ME_PASS" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS= -DVCPKG_LET_ME_PASS" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=D:/vcpkg" "-D_VCPKG_INSTALLED_DIR=D:/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF"
-- The C compiler identification is MSVC 19.40.33811.0
-- The CXX compiler identification is MSVC 19.40.33811.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.40.33807/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.40.33807/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:8 (message):
  Compiler flags are not passed consistently to try_compile!


-- Configuring incomplete, errors occurred!
ninja: build stopped: subcommand failed.

walbourn · 2024-07-02T18:36:15Z

Thanks!

The updated xbox triplet toolchain file is in this PR: #39654

fix try compile

73037ad

Neumann-A changed the title ~~[toolchain] Fix try compile handling~~ [world rebuild|toolchain] Fix try compile handling May 1, 2022

github-actions bot approved these changes May 1, 2022

View reviewed changes

Neumann-A commented May 2, 2022

View reviewed changes

scripts/buildsystems/vcpkg.cmake Outdated Show resolved Hide resolved

fix try compile in project mode

ee98271

github-actions bot approved these changes May 2, 2022

View reviewed changes

Neumann-A commented May 2, 2022

View reviewed changes

scripts/toolchains/uwp.cmake Outdated Show resolved Hide resolved

Neumann-A commented May 2, 2022

View reviewed changes

scripts/buildsystems/vcpkg.cmake Outdated Show resolved Hide resolved

try fixing qtbase

80d23d0

github-actions bot approved these changes May 2, 2022

View reviewed changes

fix regressions.

d30a535

github-actions bot approved these changes May 2, 2022

View reviewed changes

Alexander Neumann added 2 commits May 3, 2022 09:47

set policies to fix last regression

50ae753

Merge branch 'fix_try_compile' of https://github.com/Neumann-A/vcpkg …

a3b31f2

…into fix_try_compile # Conflicts: # scripts/buildsystems/vcpkg.cmake

github-actions bot approved these changes May 3, 2022

View reviewed changes

Neumann-A commented May 4, 2022

View reviewed changes

scripts/buildsystems/vcpkg.cmake Outdated Show resolved Hide resolved

Neumann-A marked this pull request as ready for review May 4, 2022 14:12

move stuff around

c82d7ee

github-actions bot previously approved these changes May 4, 2022

View reviewed changes

Cheney-W assigned Cheney-W and JackBoosY May 5, 2022

Cheney-W requested a review from JackBoosY May 5, 2022 09:45

JackBoosY added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label May 5, 2022

Cheney-W added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label May 5, 2022

Neumann-A mentioned this pull request May 9, 2022

[vcpkg/Fortran|world rebuild] Windows: Use ifort (x86|x64) or flang(arm64) #24622

Draft

7 tasks

Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 17, 2022

Neumann-A added 9 commits June 1, 2024 17:08

Merge remote-tracking branch 'upstream/master' into fix_try_compile

0a1f642

[skip ci] change indent windows toolchain to check changeset

b5c86a9

[skip ci] try different ordering

a0efcc3

[skip ci] anopther approach

d200d68

[skip ci] 4 spaces not 2

29be2f3

[skip ci] unset a few variables

6ea4658

[skip ci] reformating UWP

0ebed29

[skip ci] indent change

727b603

apply ident to all toolchains except xbox.

692680e

BillyONeal added info:reviewed Pull Request changes follow basic guidelines and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Jun 13, 2024

BillyONeal reviewed Jun 13, 2024

View reviewed changes

add test case for try_compile

7bcc75a

Merge branch 'microsoft:master' into fix_try_compile

13822a6

Merge remote-tracking branch 'origin/master' into HEAD

d375ba6

BillyONeal merged commit 9c0956e into microsoft:master Jun 19, 2024
17 checks passed

Neumann-A deleted the fix_try_compile branch June 19, 2024 21:39

BillyONeal mentioned this pull request Jul 11, 2024

[toolchain] Fix try compile handling for Xbox #39654

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[world rebuild|toolchain] Fix try compile handling #24493

[world rebuild|toolchain] Fix try compile handling #24493

Neumann-A commented May 1, 2022 •

edited

Loading

BillyONeal commented May 1, 2022

azure-pipelines bot commented May 1, 2022

Cheney-W commented May 5, 2022

Cheney-W commented Jun 17, 2022

Neumann-A commented Jun 1, 2024

BillyONeal commented Jun 13, 2024

BillyONeal Jun 13, 2024

walbourn Jun 13, 2024

BillyONeal Jun 13, 2024

Neumann-A Jun 13, 2024

Neumann-A commented Jun 13, 2024

dg0yt commented Jun 13, 2024

Neumann-A commented Jun 13, 2024

Neumann-A commented Jun 18, 2024

BillyONeal commented Jun 18, 2024

dg0yt commented Jun 19, 2024

BillyONeal commented Jun 19, 2024

walbourn commented Jun 21, 2024

BillyONeal commented Jun 22, 2024

walbourn commented Jul 2, 2024

[world rebuild|toolchain] Fix try compile handling #24493

[world rebuild|toolchain] Fix try compile handling #24493

Conversation

Neumann-A commented May 1, 2022 • edited Loading

BillyONeal commented May 1, 2022

azure-pipelines bot commented May 1, 2022

Cheney-W commented May 5, 2022

Cheney-W commented Jun 17, 2022

Neumann-A commented Jun 1, 2024

BillyONeal commented Jun 13, 2024

BillyONeal Jun 13, 2024

Choose a reason for hiding this comment

walbourn Jun 13, 2024

Choose a reason for hiding this comment

BillyONeal Jun 13, 2024

Choose a reason for hiding this comment

Neumann-A Jun 13, 2024

Choose a reason for hiding this comment

Neumann-A commented Jun 13, 2024

dg0yt commented Jun 13, 2024

Neumann-A commented Jun 13, 2024

Neumann-A commented Jun 18, 2024

BillyONeal commented Jun 18, 2024

dg0yt commented Jun 19, 2024

BillyONeal commented Jun 19, 2024

walbourn commented Jun 21, 2024

BillyONeal commented Jun 22, 2024

walbourn commented Jul 2, 2024

Neumann-A commented May 1, 2022 •

edited

Loading