[cgns] Update to 4.3.0

[panda-z]

Describe the pull request

• What does your PR fix?

  Update cgns to 4.3.0

• Which triplets are supported/not supported? Have you updated the CI baseline?

  Yes (As before)

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

[ghost]

All CLA requirements met.

[github-actions]

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/cgns/vcpkg.json

Valid values for the license field can be found in the documentation

[BillyONeal]

I was unable to build cgns[hdf5,lfs,legacy,cgnstools]:x64-windows, with the failure:

-- Could NOT find Tclsh (missing: TCL_TCLSH) 
-- Could NOT find TCL (missing: TCL_LIBRARY TCL_INCLUDE_PATH) 
-- Could NOT find TCLTK (missing: TCL_LIBRARY TCL_INCLUDE_PATH TK_LIBRARY TK_INCLUDE_PATH) 
-- Could NOT find TK (missing: TK_LIBRARY TK_INCLUDE_PATH) 
CMake Error at src/cgnstools/CMakeLists.txt:80 (message):
  The path and library needs to be defined for:

      TCL;TK

It looks like some dependencies are missing from declarations?

I pushed some other minor nitpicks.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for cgns but no changes to version or port version.
-- Version: 4.3.0
-- Old SHA: a7a3ae05ee5762213844ecee9f048e5534d99ffc
-- New SHA: 880e06dd7731cb1848c6e627992213e7e95e0749
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/cgns/vcpkg.json

Valid values for the license field can be found in the documentation

[github-actions]

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/cgns/vcpkg.json

Valid values for the license field can be found in the documentation

[JonLiu1993]

@panda-z ,I tested the features locally with the command "./vcpkg install cgns[hdf5,lfs,legacy,cgnstools]:x64-windows" failed:

CMake Error at src/cgnstools/CMakeLists.txt:80 (message):
  The path and library needs to be defined for:

      TCL;TK

[panda-z]

@JonLiu1993

Currently, the feature "cgnstools" relies on tcl and tk as dependencies. While tcl is available in vcpkg repo but cannot be located by cmake when building cgns. Tk is not currently available in vcpkg repo (#7648).

By installing ActiveTcl one can workaround the build failure issue. But that will pull in a third party binary package. I have no idea whether we should keep this feature option or not.

[JonLiu1993]

@JonLiu1993

Currently, the feature "cgnstools" relies on tcl and tk as dependencies. While tcl is available in vcpkg repo but cannot be located by cmake when building cgns. Tk is not currently available in vcpkg repo (#7648).

By installing ActiveTcl one can workaround the build failure issue. But that will pull in a third party binary package. I have no idea whether we should keep this feature option or not.

Thanks for the clarification, as you said we cannot use the feature "cgnstools" directly at the moment, I suggest to delete this feature for now

[Neumann-A]

You cannot delete existing features... this breaks the upgrade path.

[panda-z]

@Neumann-A

The "cgnstools" is not an existing feature. It is a new feature which is introduced by this PR.

However, "tools" is an existing feature which will be removed, since it is an "dummy" feature which is unused in portfile.cmake.

If this breaks the upgrade path, I can revert the changes.

[github-actions]

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/cgns/vcpkg.json

Valid values for the license field can be found in the documentation

[BillyONeal]

You cannot delete existing features... this breaks the upgrade path.

I think it's borderline because it's a non-default feature with no effects so presumably people wouldn't have installed it. On the other hand there seems to be little strong reason to remove it either.

@panda-z I think we should describe any features with no effects with "No effects, preserved for upgrade compatibility." or similar and not add new features that are broken.

[github-actions]

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/cgns/vcpkg.json

Valid values for the license field can be found in the documentation

[panda-z]

@BillyONeal Thanks for clarification. That makes sense. I've modified the description to "No effects, preserved for upgrade compatibility".

In addition, "cgnstools" is removed due to the lack of support for tcl/tk in vcpkg.

[JonLiu1993]

@panda-z ,I tested the features locally with the command "./vcpkg install cgns[*]" failed:

CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
Missing variable is:
CMAKE_Fortran_PREPROCESS_SOURCE
CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
Missing variable is:
CMAKE_Fortran_PREPROCESS_SOURCE
CMake Error at F:/Feature-test/cgns/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/share/cmake-3.22/Modules/FortranCInterface/Detect.cmake:41 (try_compile):
  Failed to generate test project build system.
Call Stack (most recent call first):
  F:/Feature-test/cgns/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/share/cmake-3.22/Modules/FortranCInterface.cmake:224 (include)
  CMakeLists.txt:168 (include)

[panda-z]

@JonLiu1993 This error may relate to the "not yet implemented" fortran feature.

[JonLiu1993]

@JonLiu1993 This error may relate to the "not yet implemented" fortran feature.

OK, I will test the other features again

[panda-z]

Can we remove the requires:author-response label? Thanks.

[JonLiu1993]

Except for the fortran feature, all features are tested successfully in the following triplet:

• x86-windows
• x64-windows
• x64-windows-static

[BillyONeal]

Thanks for the update! (If you'd be willing to submit a PR removing that patch if unnecessary that would be nice, but didn't seem worth blocking the version update for that)

[panda-z]

Thanks for merging!