-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[glog] Glog nominmax #24538
[glog] Glog nominmax #24538
Conversation
I ran " ./vcpkg x-add-version --all", and got this: |
I changed files like [cad3645], [3b48bd2] and after run .\vcpkg x-add-version --all |
My build failed again. And, the vcpkg document has been over 60Gb large. Is it possible? Or anything went wrong? |
I rebooted the computer. re-build again. Now it seems to be finished. 1.13 hours was used. |
I have installed COLMAP with vcpkg. Do I need to cmake for COLMAP? I planned to install Pycolmap, but I cannot. Got many errors. |
you need to overwrite the version via |
@whuaegeanse are you trying to fix the CI build issue? you can get the failure logs from https://dev.azure.com/vcpkg/public/_build/results?buildId=71684&view=artifacts&pathAsName=false&type=publishedArtifacts |
I run '.\vcpkg x-add-version glog --overwrite-version'. But same waring occured. I attach files what I changed. Is there a problem with that?? Or I have to do more things after change them and before run x-add-version? I'm using Windows 10x64 and MSVC19 Thank so much for your help (base) C:\colmap\vcpkg>.\vcpkg x-add-version glog --overwrite-version |
I am working on this |
What's the status now? |
@Adela0814 Done. |
Thanks for the fix! |
Describe the pull request
Fixs conflicts with freeimage when building colmap.
What does your PR fix?
Fixes [Windows] Build error colmap/colmap#1511
Which triplets are supported/not supported? Have you updated the CI baseline?
All, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes