[gtk] Add a dependency on gettext[tools] to build translation files #24596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
No portfile changes for explicit control? |
FrankXie05
added
category:port-feature
FrankXie05
requested changes
May 9, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
cc @Neumann-A |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 24596 in repo microsoft/vcpkg |
FrankXie05
approved these changes
Jun 6, 2022
ras0219-msft
requested changes
Jun 6, 2022
ports/gtk/portfile.cmake
Outdated
| @@ -17,6 +17,7 @@ vcpkg_find_acquire_program(PKGCONFIG) | |||
| get_filename_component(PKGCONFIG_DIR "${PKGCONFIG}" DIRECTORY ) | |||
| vcpkg_add_to_path("${PKGCONFIG_DIR}") # Post install script runs pkg-config so it needs to be on PATH | |||
| vcpkg_add_to_path("${CURRENT_HOST_INSTALLED_DIR}/tools/glib/") | |||
| vcpkg_add_to_path("${CURRENT_HOST_INSTALLED_DIR}/tools/gettext/bin") | |||
There was a problem hiding this comment.
Suggested change
| vcpkg_add_to_path("${CURRENT_HOST_INSTALLED_DIR}/tools/gettext/bin") |
We should instead add msgfmt to ADDITIONAL_NATIVE_BINARIES in vcpkg_configure_meson() below to ensure it's using our copy of gettext:
msgfmt='${CURRENT_HOST_INSTALLED_DIR}/tools/gettext/bin/msgfmt${VCPKG_HOST_EXECUTABLE_SUFFIX}'
There was a problem hiding this comment.
ADDITIONAL_NATIVE_BINARIESinvcpkg_configure_meson()
... undocumented ...
There was a problem hiding this comment.
Actually PATH is altered by ports/gettext/vcpkg-port-config.cmake so I removed this patch hunk.
Additionally, when checking for gettext availability meson checks for xgettext binary, not msgfmt, so your suggestion does not seem to be valid.
FrankXie05
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTK translation files are built only when gettext-tools is present
What does your PR fix?
N/A
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/