[stftpitchshift] Update to 1.4.1 #24599

jurihock · 2022-05-07T13:25:04Z

Describe the pull request

What does your PR fix?

update stftpitchshift to v1.4.1
Which triplets are supported/not supported? Have you updated the CI baseline?

all, yes
Does your PR follow the maintainer guide?

yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

…I simply don't understand... 😡

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a5d6d145164e82e67fbf91a4a30f98699d30de63 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/s-/stftpitchshift.json b/versions/s-/stftpitchshift.json
index d04954f..25dbd50 100644
--- a/versions/s-/stftpitchshift.json
+++ b/versions/s-/stftpitchshift.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "74b15f8fdcad37aed9e50f2570ef361b362cf8bf",
+      "version": "1.4.1",
+      "port-version": 0
+    },
     {
       "git-tree": "1f4a495416b6e2e3a830c8ba72eb5cf9034c68cc",
       "version": "1.3.2",

ports/stftpitchshift/portfile.cmake

Funny suggestion, to use some kind of hidden ${PORT} variable just in one place and still the port name string otherwise... Co-authored-by: Cheney Wang <38240633+Cheney-W@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for stftpitchshift but no changes to version or port version.
-- Version: 1.4.1
-- Old SHA: 74b15f8fdcad37aed9e50f2570ef361b362cf8bf
-- New SHA: 306cc6bce6fac599f2a15f6550994db455fad690
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

jurihock · 2022-05-09T08:49:19Z

@Cheney-W My original commit 1513d67 was successful, but after your suggestion 8c82315 there is a build error. Please troubleshoot...

Cheney-W · 2022-05-09T08:55:15Z

You need run the following commands in your branch:
• .\vcpkg.exe x-add-version {port name} --overwrite-version
• git add .
• git commit -m "update json"
• git push

and not just in one place like suggested by Cheney-W

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for stftpitchshift but no changes to version or port version.
-- Version: 1.4.1
-- Old SHA: 306cc6bce6fac599f2a15f6550994db455fad690
-- New SHA: e403812b23bdb6f86651104d3be9c001bea821fd
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

jurihock · 2022-05-09T18:40:08Z

Now I put the ${PORT} variable everywhere instead of the port name, although I don't understand what kind of issue it should fix.

Are there any further questions to the author of this port e.g. requirements for the "requires:author-response" label?

Cheney-W · 2022-05-10T01:56:23Z

ports/stftpitchshift/portfile.cmake

@@ -14,6 +14,17 @@ vcpkg_cmake_configure(

 vcpkg_cmake_install()

-file(INSTALL "${SOURCE_PATH}/LICENSE" DESTINATION "${CURRENT_PACKAGES_DIR}/share/stftpitchshift" RENAME copyright)
+vcpkg_cmake_config_fixup(
+  PACKAGE_NAME "${PORT}"


PACKAGE_NAME "${PORT}"
Thie sentence could be removed, PACKAGE_NAME defaults to ${PORT}.

…PORT}.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for stftpitchshift but no changes to version or port version.
-- Version: 1.4.1
-- Old SHA: e403812b23bdb6f86651104d3be9c001bea821fd
-- New SHA: 36932b4bd7c57fdc63ae75ec5117f6321e3c2ca6
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

jurihock · 2022-05-10T04:44:56Z

So what else?

Cheney-W · 2022-05-10T06:22:24Z

Thanks for your prompt reply, now just waiting for merge.

BillyONeal · 2022-05-10T18:35:57Z

Thanks for the update!

jurihock and others added 11 commits May 4, 2022 07:37

Add stftpitchshift port

e2e8570

Fix shared library build on Windows

2df3864

Run vcpkg x-add-version stftpitchshift

597e332

Update version database

9b0f855

Just increase the version counter to hopefully fix the vcpkg problem …

5363d90

…I simply don't understand... 😡

Now update both sha and version...

114c4b3

Update version database

a8c63de

Merge remote-tracking branch 'origin/master' into HEAD

4e8979d

Fix version database.

ad0ef75

Add quotes and modernize cmake helpers.

12edf99

Merge branch 'microsoft:master' into master

9c879f3

github-actions bot approved these changes May 7, 2022

View reviewed changes

Update stftpitchshift to v.1.4.1

51919a1

github-actions bot requested changes May 7, 2022

View reviewed changes

Update version database like suggested by bot

1513d67

github-actions bot approved these changes May 7, 2022

View reviewed changes

jurihock marked this pull request as ready for review May 7, 2022 21:04

jurihock changed the title ~~[stftpitchshift] release 1.4.1~~ [stftpitchshift] Update to 1.4.1 May 8, 2022

JackBoosY assigned Cheney-W May 9, 2022

Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label May 9, 2022

Cheney-W reviewed May 9, 2022

View reviewed changes

ports/stftpitchshift/portfile.cmake Outdated Show resolved Hide resolved

Cheney-W added the requires:author-response label May 9, 2022

Update ports/stftpitchshift/portfile.cmake

8c82315

Funny suggestion, to use some kind of hidden ${PORT} variable just in one place and still the port name string otherwise... Co-authored-by: Cheney Wang <38240633+Cheney-W@users.noreply.github.com>

github-actions bot requested changes May 9, 2022

View reviewed changes

Update version database

14c760a

github-actions bot approved these changes May 9, 2022

View reviewed changes

Consequently use ${PORT} everywhere...

5ded286

and not just in one place like suggested by Cheney-W

github-actions bot requested changes May 9, 2022

View reviewed changes

Update stftpitchshift.json

4c02996

github-actions bot approved these changes May 9, 2022

View reviewed changes

Cheney-W reviewed May 10, 2022

View reviewed changes

Cheney-W: Thie sentence could be removed, PACKAGE_NAME defaults to ${…

50f1a36

…PORT}.

github-actions bot requested changes May 10, 2022

View reviewed changes

Update stftpitchshift.json

4fa6267

github-actions bot approved these changes May 10, 2022

View reviewed changes

Cheney-W approved these changes May 10, 2022

View reviewed changes

Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 10, 2022

BillyONeal merged commit 0e26d20 into microsoft:master May 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stftpitchshift] Update to 1.4.1 #24599

[stftpitchshift] Update to 1.4.1 #24599

jurihock commented May 7, 2022

github-actions bot left a comment

github-actions bot left a comment

jurihock commented May 9, 2022

Cheney-W commented May 9, 2022 •

edited

Loading

github-actions bot left a comment

jurihock commented May 9, 2022

Cheney-W May 10, 2022 •

edited

Loading

github-actions bot left a comment

jurihock commented May 10, 2022

Cheney-W commented May 10, 2022

BillyONeal commented May 10, 2022

[stftpitchshift] Update to 1.4.1 #24599

[stftpitchshift] Update to 1.4.1 #24599

Conversation

jurihock commented May 7, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

jurihock commented May 9, 2022

Cheney-W commented May 9, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

jurihock commented May 9, 2022

Cheney-W May 10, 2022 • edited Loading

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

jurihock commented May 10, 2022

Cheney-W commented May 10, 2022

BillyONeal commented May 10, 2022

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

Cheney-W commented May 9, 2022 •

edited

Loading

Cheney-W May 10, 2022 •

edited

Loading