Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tclap] Update TCLAP to 1.2.5 #24644

Merged
merged 4 commits into from
May 11, 2022
Merged

[tclap] Update TCLAP to 1.2.5 #24644

merged 4 commits into from
May 11, 2022

Conversation

DevFdv
Copy link
Contributor

@DevFdv DevFdv commented May 10, 2022

  • [tclap] upgrade to 1.2.5
  • [tclap] change version-string to version as numbering is compatible and allows for better future version comparison.
  • [tclap] vcpkg x-add-version

@ghost
Copy link

ghost commented May 10, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 self-assigned this May 11, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 11, 2022
github-actions[bot]
github-actions bot approved these changes May 11, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/tclap/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 11, 2022
@BillyONeal BillyONeal merged commit 9e26f92 into microsoft:master May 11, 2022
@BillyONeal
Copy link
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DevFdv @BillyONeal @JonLiu1993