[magic-enum] Update to v0.8.0 #24646

Neargye · 2022-05-10T19:58:09Z

Describe the pull request

What does your PR fix?

Update magic-enum to v0.8.0

Changelog:
https://github.com/Neargye/magic_enum/releases/tag/v0.8.0

Which triplets are supported/not supported? Have you updated the CI baseline?

All, No

Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

github-actions

Use the version scheme "version" instead of "version-string" in port "magic-enum".

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/magic-enum/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/magic-enum/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for magic-enum but no changes to version or port version.
-- Version: 0.8.0#1
-- Old SHA: 4eb8c4e7bf5e09137569cec58b0cacb2a5bfaefa
-- New SHA: 430676f0098e9934284c3ad682991335d66caf60
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Thomas1664

Additionally, please put paths in cmake inside quotes.

ports/magic-enum/vcpkg.json

versions/m-/magic-enum.json

ports/magic-enum/vcpkg.json

ports/magic-enum/portfile.cmake

Neargye · 2022-05-10T20:26:18Z

Additionally, please put paths in cmake inside quotes.

Which path are you talking about?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for magic-enum but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 4eb8c4e7bf5e09137569cec58b0cacb2a5bfaefa
-- New SHA: 21801804728d08d9c3c3f63b9007dfcf339d63e7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout acca474962d8bc714ba555ec0c21b0dabee4e79d -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 2309e16..dd01700 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4346,7 +4346,7 @@
     },
     "magic-enum": {
       "baseline": "0.8.0",
-      "port-version": 1
+      "port-version": 0
     },
     "magic-get": {
       "baseline": "2019-09-02",

ports/magic-enum/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for magic-enum but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 4eb8c4e7bf5e09137569cec58b0cacb2a5bfaefa
-- New SHA: 21801804728d08d9c3c3f63b9007dfcf339d63e7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for magic-enum but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 4eb8c4e7bf5e09137569cec58b0cacb2a5bfaefa
-- New SHA: 8fc85208865a1220c53e09e1f85ed315c55befe0
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for magic-enum but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 4eb8c4e7bf5e09137569cec58b0cacb2a5bfaefa
-- New SHA: d591d0f3c913481cffd7a94eb4bc193877164679
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Neargye · 2022-05-10T20:37:57Z

I need run ./vcpkg x-add-version --all --overwrite-version ?

Thomas1664 · 2022-05-10T20:55:08Z

I need run ./vcpkg x-add-version --all --overwrite-version ?

Yes, but only after you're done fixing CI issues

Thomas1664 · 2022-05-10T20:57:54Z

You need to add these dependencies:

In the ports that use the new function, you have to add the corresponding dependencies:
{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

versions/m-/magic-enum.json

Thomas1664 · 2022-05-10T21:01:20Z

e.g. this and line 27 as well

Please add quotes in portfile.cmake line 27 as well.

Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for magic-enum but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 4eb8c4e7bf5e09137569cec58b0cacb2a5bfaefa
-- New SHA: d591d0f3c913481cffd7a94eb4bc193877164679
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for magic-enum but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: d591d0f3c913481cffd7a94eb4bc193877164679
-- New SHA: 54d921619501885c2e0fc9b2b0749397496603af
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for magic-enum but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 54d921619501885c2e0fc9b2b0749397496603af
-- New SHA: 8517adc00e7b19963e48f7858ea60089aa6810ec
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

ports/magic-enum/portfile.cmake

BillyONeal · 2022-05-11T23:47:00Z

Thanks for the update and modernization!

Neargye added 2 commits May 10, 2022 23:54

[magic-enum] Update to v0.8.0

dc57893

x-add-version

63cfbb9

github-actions bot approved these changes May 10, 2022

View reviewed changes

fix deprecated

30d10bf

github-actions bot requested changes May 10, 2022

View reviewed changes

Thomas1664 suggested changes May 10, 2022

View reviewed changes

ports/magic-enum/vcpkg.json Outdated Show resolved Hide resolved

versions/m-/magic-enum.json Outdated Show resolved Hide resolved

ports/magic-enum/vcpkg.json Outdated Show resolved Hide resolved

ports/magic-enum/portfile.cmake Outdated Show resolved Hide resolved

fix review

5ca8fb5

github-actions bot requested changes May 10, 2022

View reviewed changes

fix version

8e277f9

Thomas1664 reviewed May 10, 2022

View reviewed changes

ports/magic-enum/portfile.cmake Outdated Show resolved Hide resolved

Thomas1664 reviewed May 10, 2022

View reviewed changes

ports/magic-enum/portfile.cmake Outdated Show resolved Hide resolved

github-actions bot requested changes May 10, 2022

View reviewed changes

Update ports/magic-enum/portfile.cmake

64e58ec

Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>

github-actions bot requested changes May 10, 2022

View reviewed changes

Update ports/magic-enum/portfile.cmake

15f3c4c

Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>

github-actions bot requested changes May 10, 2022

View reviewed changes

Thomas1664 reviewed May 10, 2022

View reviewed changes

versions/m-/magic-enum.json Outdated Show resolved Hide resolved

Update versions/m-/magic-enum.json

dd4272c

Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>

github-actions bot requested changes May 10, 2022

View reviewed changes

fix review

01f9a2a

github-actions bot requested changes May 10, 2022

View reviewed changes

overwrite-version

9574f2a

github-actions bot approved these changes May 10, 2022

View reviewed changes

fix cmake

112fb96

github-actions bot requested changes May 10, 2022

View reviewed changes

Thomas1664 reviewed May 10, 2022

View reviewed changes

ports/magic-enum/portfile.cmake Outdated Show resolved Hide resolved

Neargye added 2 commits May 11, 2022 01:54

fix onfig_fixup

f8ac053

overwrite-version

7daa6bf

github-actions bot approved these changes May 10, 2022

View reviewed changes

Neargye mentioned this pull request May 10, 2022

[magic-enum] Update to the latest version #24629

Closed

JonLiu1993 self-assigned this May 11, 2022

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 11, 2022

JonLiu1993 requested changes May 11, 2022

View reviewed changes

ports/magic-enum/portfile.cmake Outdated Show resolved Hide resolved

ports/magic-enum/portfile.cmake Show resolved Hide resolved

JonLiu1993 added requires:author-response and removed requires:author-response labels May 11, 2022

Neargye added 2 commits May 11, 2022 12:52

delete extra blank line

acf1ecd

overwrite-version

b10a6ba

JonLiu1993 removed the requires:author-response label May 11, 2022

JonLiu1993 approved these changes May 11, 2022

View reviewed changes

github-actions bot approved these changes May 11, 2022

View reviewed changes

JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 11, 2022

BillyONeal merged commit 188ff7a into microsoft:master May 11, 2022

Neargye deleted the mg_080 branch May 12, 2022 07:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[magic-enum] Update to v0.8.0 #24646

[magic-enum] Update to v0.8.0 #24646

Neargye commented May 10, 2022

github-actions bot left a comment

github-actions bot left a comment

Thomas1664 left a comment •

edited

Loading

Neargye commented May 10, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

Neargye commented May 10, 2022

Thomas1664 commented May 10, 2022 •

edited

Loading

Thomas1664 commented May 10, 2022 •

edited

Loading

Thomas1664 commented May 10, 2022 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

BillyONeal commented May 11, 2022

[magic-enum] Update to v0.8.0 #24646

[magic-enum] Update to v0.8.0 #24646

Conversation

Neargye commented May 10, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Thomas1664 left a comment • edited Loading

Choose a reason for hiding this comment

Neargye commented May 10, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Neargye commented May 10, 2022

Thomas1664 commented May 10, 2022 • edited Loading

Thomas1664 commented May 10, 2022 • edited Loading

Thomas1664 commented May 10, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

BillyONeal commented May 11, 2022

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

Thomas1664 left a comment •

edited

Loading

Thomas1664 commented May 10, 2022 •

edited

Loading

Thomas1664 commented May 10, 2022 •

edited

Loading

Thomas1664 commented May 10, 2022 •

edited

Loading