-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[akali] Update to v1.43 #24648
[akali] Update to v1.43 #24648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for akali have changed but the version was not updated
version: 1.43
old SHA: fa73d3ef836e5926e63203d963456e12476536c8
new SHA: 1ba84a60993ac2818b0ccdfb9c0e529402c13d86
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/akali/portfile.cmake
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/akali/vcpkg.json
Valid values for the license field can be found in the documentation
@winsoft666 Thanks for your PR! Can you please correct the |
Sorry, I don't know how to correct the |
@winsoft666 Do you mind if I make changes on your PR? |
Please do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/akali/vcpkg.json
Valid values for the license field can be found in the documentation
Thanks for the update and modernization! |
PASSING, REMOVE FROM FAIL LIST: akali:x64-windows-static-md (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). Probably fixed by microsoft#24648 REGRESSION: angle:x64-windows-static-md failed with BUILD_FAILED. If expected, add angle:x64-windows-static-md=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: angle:arm-uwp failed with BUILD_FAILED. If expected, add angle:arm-uwp=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt. ICE :( https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/1472813
PASSING, REMOVE FROM FAIL LIST: akali:x64-windows-static-md (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). Probably fixed by #24648 REGRESSION: angle:x64-windows-static-md failed with BUILD_FAILED. If expected, add angle:x64-windows-static-md=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: angle:arm-uwp failed with BUILD_FAILED. If expected, add angle:arm-uwp=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt. ICE :( https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/1472813
Describe the pull request
What does your PR fix?
Update to v1.43
Which triplets are supported/not supported? Have you updated the CI baseline?
<linux, windows, macOS / arm, uwp>,
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?