Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cudnn] Add /usr/ to find_library for cudnn for ArchLinux #24663

Merged
merged 1 commit into from
May 12, 2022

Conversation

umar456
Copy link
Contributor

@umar456 umar456 commented May 12, 2022

cuDNN is installed in the usr directory in Arch Linux. The find_library function cannot find cuDNN because it doesn't look in that directory

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented May 12, 2022

CLA assistant check
All CLA requirements met.

@Adela0814 Adela0814 changed the title Add /usr/ to find_library for cudnn for ArchLinux [cudnn] Add /usr/ to find_library for cudnn for ArchLinux May 12, 2022
@Adela0814
Copy link
Contributor

@cenit Can you help confirm if this change is reasonable?

@cenit
Copy link
Contributor

cenit commented May 12, 2022

seems right!

@Adela0814 Adela0814 added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels May 12, 2022
@dg0yt
Copy link
Contributor

dg0yt commented May 12, 2022

I get the impression that the actual root problem is that this port should use a CMakeLists.txt and operate in project mode, instead of implementing everything in portfile.cmake, i.e. script mode.
(Doesn't portfile.cmake partially duplicate FindCUDNN.cmake?)

@BillyONeal
Copy link
Member

@dg0yt I'm pretty sure this port predates almost any reasonable built-in CMake behavior. It's possible that now we could rely on built-ins and do something like your suggestion here, but I don't think we need to suggest such a complete overhaul here when this will work.

@umar456 Thanks for the bug fix! I agree with @dg0yt that using more standard ways to get at this stuff would be nice if you'd be willing to contribute such a change as a followup PR.

@BillyONeal BillyONeal merged commit 0c954fa into microsoft:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cuDNN] build failure on x64-linux
5 participants