Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nlohmann-json] Add feature JSON_Diagnostics #24672

Merged
merged 1 commit into from
May 13, 2022

Conversation

Adela0814
Copy link
Contributor

Fix #24605
Add feature JSON_Diagnostics

All features have been tested successfully in the following triplet:

x64-windows
x86-windows
x64-windows-static

@Adela0814 Adela0814 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels May 12, 2022
@Adela0814 Adela0814 marked this pull request as ready for review May 13, 2022 05:42
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 13, 2022
@BillyONeal
Copy link
Member

Thanks for the new feature!

@BillyONeal BillyONeal merged commit 38910e6 into microsoft:master May 13, 2022
@njakob
Copy link
Contributor

njakob commented May 14, 2022

Thank you for picking this up @Adela0814!

@Adela0814 Adela0814 deleted the Dev/Mengna/nlohmann-json branch January 16, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nlohmann-json] Add JSON_DIAGNOSTICS support
5 participants