Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fontconfig][freetds][qtwebengine] Take gperf from vcpkg #24677

Merged

Conversation

talregev
Copy link
Contributor

Take gperf from vcpkg tool if possible
Fixes #24518

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for fontconfig have changed but the version was not updated
version: 2.14.0#1
old SHA: b1b1de99dba230f78c88bb9d73329bed77227ad4
new SHA: 6b861c853e150858980327e79536b43aeb7153f6
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@talregev talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from a18c93c to 492cb05 Compare May 12, 2022 12:19
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for fontconfig have changed but the version was not updated
version: 2.14.0#2
old SHA: 6b861c853e150858980327e79536b43aeb7153f6
new SHA: c6736d0a4a26971a88c0ec20ff8597ab8b9ed53d
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@talregev talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from 492cb05 to 6245a66 Compare May 12, 2022 12:23
@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 13, 2022
@talregev
Copy link
Contributor Author

@BillyONeal What do you think?

@LilyWangLL LilyWangLL requested a review from BillyONeal May 16, 2022 03:00
@BillyONeal BillyONeal added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label May 16, 2022
@talregev
Copy link
Contributor Author

@BillyONeal @ras0219-msft Any news from team discussion?

@talregev talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from 6245a66 to a19e2e6 Compare May 26, 2022 03:08
@talregev talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from a19e2e6 to 7978602 Compare May 26, 2022 03:45
@talregev talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from 7978602 to 132233b Compare May 26, 2022 03:47
@talregev talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from 132233b to b2ae44b Compare May 26, 2022 08:47
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for fontconfig have changed but the version was not updated
version: 2.14.0#2
old SHA: 5306dd9662c813ba6e18d0b6aaa3c2c35f14038f
new SHA: 54f599dd541f7721dcc68e06c328e55098d0f9b5
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@talregev talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from b2ae44b to fcf0b34 Compare May 26, 2022 08:48
@ras0219-msft
Copy link
Contributor

I've fixed gperf to install the executable into a subdirectory of tools -- could you please pull my changes into this branch?

git fetch https://github.com/ras0219-msft/vcpkg dev/roschuma/pr24677
git merge FETCH_HEAD

@ras0219-msft ras0219-msft added requires:author-response and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels May 26, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/gperf/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gperf/vcpkg.json
  • ports/kf5codecs/vcpkg.json
  • ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

@talregev
Copy link
Contributor Author

I've fixed gperf to install the executable into a subdirectory of tools -- could you please pull my changes into this branch?

git fetch https://github.com/ras0219-msft/vcpkg dev/roschuma/pr24677
git merge FETCH_HEAD

@ras0219-msft done.

@talregev
Copy link
Contributor Author

@ras0219-msft I think ci is break because of your fix.

ports/freetds/portfile.cmake Outdated Show resolved Hide resolved
ports/kf5codecs/portfile.cmake Outdated Show resolved Hide resolved
@talregev
Copy link
Contributor Author

talregev commented May 27, 2022

@dg0yt @JackBoosY @ras0219-msft
Can you help me fix kf5codecs?

Installing 44/44 kf5codecs:x64-linux...
Building kf5codecs[core]:x64-linux...
-- Downloading https://github.com/KDE/kcodecs/archive/v5.89.0.tar.gz -> KDE-kcodecs-v5.89.0.tar.gz...
-- Extracting source /home/ubuntu/vcpkg/downloads/KDE-kcodecs-v5.89.0.tar.gz
-- Using source at /home/ubuntu/vcpkg/buildtrees/kf5codecs/src/v5.89.0-a370638e5e.clean
-- Configuring x64-linux-rel
-- Building x64-linux-rel
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:158 (message):
    Command failed: /snap/cmake/1088/bin/cmake --build . --config Release --target install -- -v -j2
    Working Directory: /home/ubuntu/vcpkg/buildtrees/kf5codecs/x64-linux-rel
    See logs for more information:
      /home/ubuntu/vcpkg/buildtrees/kf5codecs/install-x64-linux-rel-out.log

Call Stack (most recent call first):
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_build.cmake:112 (vcpkg_execute_build_process)
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_install.cmake:41 (vcpkg_cmake_build)
  ports/kf5codecs/portfile.cmake:19 (vcpkg_cmake_install)
  scripts/ports.cmake:146 (include)

error:
/bin/sh: 1: /home/ubuntu/vcpkg/installed/x64-linux/tools/gperf: Permission denied
install-x64-linux-rel-out.log


Fixed.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/gperf/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gperf/vcpkg.json
  • ports/kf5codecs/vcpkg.json
  • ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/gperf/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gperf/vcpkg.json
  • ports/kf5codecs/vcpkg.json
  • ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/gperf/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gperf/vcpkg.json
  • ports/kf5codecs/vcpkg.json
  • ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gperf/vcpkg.json
  • ports/kf5codecs/vcpkg.json
  • ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

@talregev
Copy link
Contributor Author

talregev commented May 28, 2022

@BillyONeal @ras0219-msft @JackBoosY @LilyWangLL
Ready for review.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 1, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one final thing. LGTM after that fix!

ports/qtwebengine/vcpkg.json Show resolved Hide resolved
@ras0219-msft ras0219-msft changed the title [fontconfig] Take gperf from vcpkg tool if possible [fontconfig][freetds][qtwebengine] Take gperf from vcpkg Jun 1, 2022
@talregev talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from 970cacf to 4e97ff5 Compare June 1, 2022 17:55
@talregev talregev requested a review from ras0219-msft June 1, 2022 17:55
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gperf/vcpkg.json
  • ports/kf5codecs/vcpkg.json
  • ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

@talregev
Copy link
Contributor Author

talregev commented Jun 1, 2022

@ras0219-msft Ready for review.

@ras0219-msft ras0219-msft merged commit a2d8a7c into microsoft:master Jun 2, 2022
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jun 2, 2022
[fontconfig][freetds][qtwebengine] Take gperf from vcpkg (microsoft#24677)
@talregev talregev deleted the TalR/fontconfig_gperf_vcpkg_tools branch June 3, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fontconfig] gperf dependency from vcpkg
8 participants