Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcapplusplus] Update to 22.05 #24697

Merged
merged 6 commits into from
May 16, 2022
Merged

Conversation

seladb
Copy link
Contributor

@seladb seladb commented May 13, 2022

Update PcapPlusPlus port to v22.05

  • What does your PR fix?

    Update PcapPlusPlus to v22/05

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <all / linux, windows, ...>, <Yes/No>

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@seladb
Copy link
Contributor Author

seladb commented May 13, 2022

PcapPlusPlus versions do not follow SemVer, they follow CalVer. The build is failing because of that. What's the way to fix it?

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 13, 2022
seladb and others added 4 commits May 13, 2022 09:00
Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>
@JonLiu1993
Copy link
Member

JonLiu1993 commented May 16, 2022

PcapPlusPlus versions do not follow SemVer, they follow CalVer. The build is failing because of that. What's the way to fix it?

"22.05" doesn‘t conform to the version format rules and cannot use ./vcpkg format-manifest ports/pcapplusplus/vcpkg.json to format its format, so I changed it to "version-string" and then re-submitted push after formatting vcpkg.json , you can refer to the version format rules here

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 16, 2022
@BillyONeal BillyONeal merged commit d1135a5 into microsoft:master May 16, 2022
@BillyONeal
Copy link
Member

Thanks for the update!

@seladb seladb deleted the pcapplusplus-22.05 branch May 16, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants