-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builing nuspell[tools] on Mingw #24715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the version scheme "version" instead of "version-string" in port "getopt".
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/getopt/vcpkg.json
Valid values for the license field can be found in the documentation
Already tested feature tools on x86-windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the version scheme "version" instead of "version-string" in port "getopt".
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/getopt/vcpkg.json
Valid values for the license field can be found in the documentation
Thanks for the fix! |
Describe the pull request
What does your PR fix?
Fixes building port nuspell on mingw triplet.
Which triplets are supported/not supported? Have you updated the CI baseline?
All, Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes