Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builing nuspell[tools] on Mingw #24715

Merged
merged 4 commits into from
May 18, 2022
Merged

Conversation

dimztimz
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes building port nuspell on mingw triplet.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All, Yes

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the version scheme "version" instead of "version-string" in port "getopt".

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/getopt/vcpkg.json

Valid values for the license field can be found in the documentation

@JackBoosY JackBoosY added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label May 16, 2022
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 16, 2022
@JackBoosY
Copy link
Contributor

Already tested feature tools on x86-windows.

@JackBoosY JackBoosY added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels May 16, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the version scheme "version" instead of "version-string" in port "getopt".

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/getopt/vcpkg.json

Valid values for the license field can be found in the documentation

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 18, 2022
@BillyONeal BillyONeal merged commit 261ca0d into microsoft:master May 18, 2022
@BillyONeal
Copy link
Member

Thanks for the fix!

@dimztimz dimztimz deleted the nuspell-mingw branch October 1, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants