Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenJPEG] Update to 2.5.0 #24734

Merged
merged 13 commits into from
May 19, 2022
Merged

[OpenJPEG] Update to 2.5.0 #24734

merged 13 commits into from
May 19, 2022

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented May 16, 2022 •
edited
Loading

Blocked on: uclouvain/openjpeg#1422 fixed it myself and opened a PR upstream

github-actions[bot]
github-actions bot approved these changes May 16, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/openjpeg/vcpkg.json

Valid values for the license field can be found in the documentation

@Neumann-A
Copy link
Contributor Author

You have modified or added at least one vcpkg.json where you should check the license field.

Somebody mind telling me what type of BSD that is ? (https://github.com/uclouvain/openjpeg/blob/master/LICENSE)

@Neumann-A Neumann-A mentioned this pull request May 16, 2022
Closed
@rouault
Copy link

rouault commented May 16, 2022

Somebody mind telling me what type of BSD that is ?

it is written in the license :-) "2-clauses BSD License" ==> https://spdx.org/licenses/BSD-2-Clause.html

Adela0814
Adela0814 suggested changes May 17, 2022
View reviewed changes
ports/openjpeg/portfile.cmake Outdated Show resolved Hide resolved
ports/openjpeg/vcpkg.json Show resolved Hide resolved
@Adela0814 Adela0814 added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels May 17, 2022
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 19, 2022
@BillyONeal
Copy link
Member

Upstream merged the thing https://github.com/uclouvain/openjpeg/pull/1423/files

@BillyONeal BillyONeal merged commit 8da5d2b into microsoft:master May 19, 2022
@BillyONeal
Copy link
Member

Thanks for the update!

@Neumann-A Neumann-A deleted the update_openjpeg branch May 19, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adela0814 Adela0814 Adela0814 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Cheney-W Cheney-W

@Adela0814 Adela0814

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Neumann-A @rouault @BillyONeal @Adela0814 @Cheney-W