Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[akali] Update string replace method to embed AKALI_STATIC #24741

Merged
merged 14 commits into from
May 18, 2022

Conversation

winsoft666
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Fix string replace bug in vcpkg.json

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <linux, windows, macos / arm>,

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@Cheney-W Cheney-W self-assigned this May 17, 2022
@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels May 17, 2022
@ras0219-msft ras0219-msft changed the title [akali] Update string replace method in vcpkg.json [akali] Update string replace method to embed AKALI_STATIC May 17, 2022
@BillyONeal BillyONeal merged commit 8de52b0 into microsoft:master May 18, 2022
@BillyONeal
Copy link
Member

Thanks for the cleanup!

@JonLiu1993
Copy link
Member

@winsoft666, The akali port cannot be downloaded now because the package link is invalid. I can't visit the homepage of akali https://github.com/winsoft666/akali now. I wonder if this library no longer exists? Or changed to another name?

@winsoft666
Copy link
Contributor Author

winsoft666 commented Apr 10, 2023 via email

@JonLiu1993
Copy link
Member

@winsoft666, Thank you for your confirmation, I have submitted a PR in vcpkg to set the akali port to empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants