-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[akali] Update string replace method to embed AKALI_STATIC #24741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheney-W
added
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
labels
May 17, 2022
ras0219-msft
changed the title
[akali] Update string replace method in vcpkg.json
[akali] Update string replace method to embed AKALI_STATIC
May 17, 2022
Thanks for the cleanup! |
@winsoft666, The akali port cannot be downloaded now because the package link is invalid. I can't visit the homepage of akali https://github.com/winsoft666/akali now. I wonder if this library no longer exists? Or changed to another name? |
Please forgive me for replying to you so late. winsoft666/akali project had to be removed dut to sensitive data.
could you help me remove this project from the library?
| |
smart7178
|
|
***@***.***
|
---- Replied Message ----
| From | ***@***.***> |
| Date | 4/4/2023 15:02 |
| To | ***@***.***> |
| Cc | ***@***.***> ,
***@***.***> |
| Subject | Re: [microsoft/vcpkg] [akali] Update string replace method to embed AKALI_STATIC (PR #24741) |
@winsoft666, The akali port cannot be downloaded now because the package link is invalid. I can't visit the homepage of akali https://github.com/winsoft666/akali now. I wonder if this library no longer exists? Or changed to another name?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@winsoft666, Thank you for your confirmation, I have submitted a PR in vcpkg to set the akali port to empty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fix string replace bug in vcpkg.json
Which triplets are supported/not supported? Have you updated the CI baseline?
<linux, windows, macos / arm>,
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/