Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libuv] update to 1.44.1 and use official CMakeLists #24745

Merged
merged 43 commits into from
Jul 8, 2022

Conversation

JonLiu1993
Copy link
Member

Fix #24744

Update libuv to the latest version 1.44.1

Note: no feature need to test

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels May 17, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 306c9a9e22e4a4425e21da69d141e8b102a5b956 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index dabe298..cce2918 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4149,7 +4149,7 @@
       "port-version": 11
     },
     "libuv": {
-      "baseline": "1.44.1",
+      "baseline": "1.43.0",
       "port-version": 0
     },
     "libuvc": {

@hihig2001
Copy link

hope 'x64_linux' has fixed soon, so i can access to it!

@JonLiu1993
Copy link
Member Author

JonLiu1993 commented May 24, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hihig2001
Copy link

hihig2001 commented May 24, 2022

i don't know about 'wpilib' at all but it seems libuv has failed with wpilib.
and according to below link
https://vcpkg.info/port/wpilib
current version of wpilib is '2020.3.2' which is way behind recent version(2022.4.1) according to this
https://github.com/wpilibsuite/allwpilib/tags
it might there are chance that linux version of wpilib might failed with recent libuv?
well cause i don't know about 'wpilib' at all, it is little unsure that what should i do next.
should i request to update this library?

@JonLiu1993
Copy link
Member Author

i don't know about 'wpilib' at all but it seems libuv has failed with wpilib. and according to below link https://vcpkg.info/port/wpilib current version of wpilib is '2020.3.2' which is way behind recent version(2022.4.1) according to this https://github.com/wpilibsuite/allwpilib/tags it might there are chance that linux version of wpilib might failed with recent libuv? well cause i don't know about 'wpilib' at all, it is little unsure that what should i do next. should i request to update this library?

@hihig2001, I'm trying to solve the error that ci burst out, the strange thing is that I can't reproduce this problem on my local linux machine, I can successfully install libuv on my local linux machine

-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Installing: /home/test/vcpkg/packages/libuv_x64-linux/share/libuv/copyright
-- Performing post-build validation
-- Performing post-build validation done
Elapsed time to handle libuv:x64-linux: 4.525 s

Total elapsed time: 12.09 s

libuv provides CMake targets:
    # this is heuristically generated, and may not be correct
    find_package(unofficial-libuv CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::libuv::libuv)

@JonLiu1993
Copy link
Member Author

i don't know about 'wpilib' at all but it seems libuv has failed with wpilib. and according to below link https://vcpkg.info/port/wpilib current version of wpilib is '2020.3.2' which is way behind recent version(2022.4.1) according to this https://github.com/wpilibsuite/allwpilib/tags it might there are chance that linux version of wpilib might failed with recent libuv? well cause i don't know about 'wpilib' at all, it is little unsure that what should i do next. should i request to update this library?

I will try update wpilib to the latest version together

ports/libuv/fix-ci-error.patch Outdated Show resolved Hide resolved
@hihig2001
Copy link

@JonLiu1993
Copy link
Member Author

I have commit a issue to libuv upstream, let's wait for upstream's response

@bnoordhuis
Copy link

Libuv's CMakeLists.txt sets -D_GNU_SOURCE. My guess is that something in vcpkg's cmake config overrides the defines. OPTIONS_DEBUG, perhaps?

@hihig2001
Copy link

Any news here? Is there are any guys investigating the issue?

@JackBoosY JackBoosY requested review from LilyWangLL and removed request for JackBoosY July 6, 2022 08:37
github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
scripts/test_ports/cmake/vcpkg.json Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
JackBoosY added 2 commits July 6, 2022 08:06
github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jul 8, 2022
@vicroms vicroms merged commit 72ef222 into microsoft:master Jul 8, 2022
@hihig2001
Copy link

hihig2001 commented Jul 11, 2022

hi guys i got this error from 'uvw' in vcpkg.
i'm using 'vcpkg.json' and constrained version by specifying builtin-baseline

"builtin-baseline": "98f8d00e89fb6a8019c2045cfa1edbe9d92d3405"

if there are anything that i need to modify to make it work please let me know about it.

1> [CMake] CMake Error at C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake:824 (_find_package):
1> [CMake] Could not find a package configuration file provided by "unofficial-libuv"
1> [CMake] with any of the following names:
1> [CMake]
1> [CMake] unofficial-libuvConfig.cmake
1> [CMake] unofficial-libuv-config.cmake
1> [CMake]
1> [CMake] Add the installation prefix of "unofficial-libuv" to CMAKE_PREFIX_PATH or
1> [CMake] set "unofficial-libuv_DIR" to a directory containing one of the above
1> [CMake] files. If "unofficial-libuv" provides a separate development package or
1> [CMake] SDK, be sure it has been installed.
1> [CMake] Call Stack (most recent call first):
1> [CMake] out/build/windows-msvc-debug-hard-mode/vcpkg_installed/x64-windows/share/uvw/uvw-config.cmake:1 (find_package)
1> [CMake] C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake:824 (_find_package)
1> [CMake] knuckles/CMakeLists.txt:13 (find_package)

@hihig2001 hihig2001 mentioned this pull request Jul 11, 2022
@JonLiu1993 JonLiu1993 deleted the dev/Jon/libuv branch July 11, 2022 07:42
BillyONeal added a commit that referenced this pull request Jan 18, 2023
* [onnx] feature: foxi

* https://github.com/houseroad/foxi
    * install the project's copyright (MIT)
* pytorch requires `foxi_loader`

The CMake target will be renamed to `onnxifi_*` for convenience.

* [onnx] force onnx/onnx_proto static in Windows

Checked the protject's CI logs.  It turned out onnx/onnx_proto are ALWAYS static.
Specify it in CMakeLists.txt because vcpkg configures `BUILD_SHARED_LIBS=ON`
If the triplet requires it.

There are no `ONNXIFI_ENABLE_EXT=ON` case.
Removed the misused build options in portfile.

Add port feature `protobuf-lite` which is in build option.

* [onnx] support windows static triplets

* remove SHARED for `onnxifi_wrapper` and `onnxifi_dummy`

* [onnx] fix wrong LICENSE install

* [onnx] remove feature 'foxi'

* also remove redundant part in patch files

* [libtorch] rework patch files

* [libtorch] config fixup ATen, Torch

* use `link_libraries` to vcpkg installed folder
  * future work may use library names without `find_library`
* update versions JSON to use `version-semver`

* [libtorch] make shared only

* Caffe2 is exported when BUILD_SHARED_LIBS

* [libtorch] remove headers after install

* [libtorch] rewrite patches and feature options

* checked osx / linux build

* [libtorch] use eigen3 always

* Caffe2 eigen_utils.h requires it

* [libtorch] error if BLAS feature collision

* [libtorch] remove !static

* [libtorch] replace vcpkg_find_acquire_program

* let's see python3 from find_program supports

* Dependency python3

* [libtorch] migrate works from luncliff/vcpkg-registry

* Update target version and dependencies
* Removed unsupported features

* [libtorch] misc fix, update version, baseline

* fix merge confict for 'onnx'

* [libtorch] install pip packages

* typing-extensions, pyyaml

* [libtorch] turn off Metal options

* [onnx] revert 'onnx' changes

* [libtorch] refine patches

* [libtorch] link with foxi_loader

* removed wrong onnx related source changes

* [libtorch] update git-tree

* [libtorch] reduce patch size

* [libtorch] find numa and activate USE_NUMA

* Update ports/libtorch/portfile.cmake

Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>

* Update ports/libtorch/portfile.cmake

Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>

* Update ports/libtorch/portfile.cmake

Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>

* [libtorch] fix mistype and update version JSON

* Add double quotes

* version

* Fix support expression

* version

* [libtorch] update cpuinfo usage

* #23944
* update version

* [tensorpipe] fix linux install

* find_package(Tensorpipe) may fail because of case mismatch

* [tensorpipe] update versions JSON

* [libtorch] fix feature failures

* [libtorch] remove CUDA feature

* [libtorch] giveup 'fbgemm' feature

* [libtorch] use mpi, openmpi in Linux

* [libtorch] fix glog link error

* [tensorpipe] bump port version

* see #23569

* [libtorch] fix patch list

* [libtorch] use official libuv config

* see #24745

* Update ports/libtorch/portfile.cmake

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

* Update ports/libtorch/portfile.cmake

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

* update versions JSON

* revert unnecessary 'nnpack' changes

* Update ports/libtorch/portfile.cmake

Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>

* [libtorch] use vcpkg-get-python-packages

* [libtorch] provide path of python3

* Update ports/libtorch/portfile.cmake

Co-authored-by: Billy O'Neal <bion@microsoft.com>

* Fix version database.

* [libtorch] use openmpi in linux/osx

* [libtorch] update to v1.12.1

* [libtorch] find_program(python3, python)

* [libtorch] provide PYTHON_EXECUTABLE directly

* [xnnpack] update to 2022-02-17

* [xnnpack] use C11, C++11

* [libtorch] more patches, DISABLE_PARALLEL_CONFIGURE

* [libtorch] allow static torch_cpu build

* Revert "[libtorch] allow static torch_cpu build"

This reverts commit 5fd4ef0.

* [libtorch] find_package(BLAS)

* [libtorch] simplify Python3, NumPy option use

* [libtorch] fix install in Windows

* [libtorch] exclude torch_global_deps in Windows

* [libtorch] platform of nnpack feature

* [libtorch] fix MPI option in Windows

* [libtorch] fixing LNK1161

* [libtorch] fix some mistypes

* [libtorch] define NOMINMAX for c10

* [libtorch] disable vulkan feature in Windows

* ci.baseline.txt: allow libtorch failure

* fails with Visual Studio 2022 17.4.2
* requires 17.4.3+

* Enable testing port on Windows

* [caffe2] redirect to libtorch

* update baseline

Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com>
Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>
Co-authored-by: Billy Robert O'Neal <bion@microsoft.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
@Adela0814 Adela0814 mentioned this pull request Apr 18, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libuv] update to <1.44.1>
9 participants