Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libass] update to 0.16.0 #24749

Merged
merged 2 commits into from
May 19, 2022
Merged

Conversation

Masaiki
Copy link
Contributor

@Masaiki Masaiki commented May 17, 2022

rewrite part of the CMakeLists.txt for matching the lastest configure.ac

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/libass/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libass/vcpkg.json

Valid values for the license field can be found in the documentation

@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label May 18, 2022
ports/libass/CMakeLists.txt Outdated Show resolved Hide resolved
@Masaiki Masaiki force-pushed the libass-update-0160 branch from e61bb6d to 1953b90 Compare May 18, 2022 06:31
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/libass/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libass/vcpkg.json

Valid values for the license field can be found in the documentation

ports/libass/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/libass/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libass/vcpkg.json

Valid values for the license field can be found in the documentation

@FrankXie05
Copy link
Contributor

@Masaiki One last bit of nitpicking advice, are you able to modernize the port. We're using the new function now, I'll keep it open for 12 hours, and if there's no response, we'll merge it and modernize it in the next update. Reference message #24749 (review)
😀

@Masaiki Masaiki force-pushed the libass-update-0160 branch from 36241f2 to 2124cf9 Compare May 19, 2022 02:48
@Masaiki
Copy link
Contributor Author

Masaiki commented May 19, 2022

@Masaiki One last bit of nitpicking advice, are you able to modernize the port. We're using the new function now, I'll keep it open for 12 hours, and if there's no response, we'll merge it and modernize it in the next update. Reference message #24749 (review) 😀

Done. Thanks for your following up.

@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 19, 2022
@BillyONeal
Copy link
Member

Thanks for the update!

@BillyONeal BillyONeal closed this May 19, 2022
@BillyONeal BillyONeal reopened this May 19, 2022
@BillyONeal BillyONeal merged commit 63e3975 into microsoft:master May 19, 2022
@Masaiki Masaiki deleted the libass-update-0160 branch May 20, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants