Fix angle macos build #24750
Merged
Fix angle macos build #24750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/angle/vcpkg.json
Valid values for the license field can be found in the documentation
JackBoosY
approved these changes
May 18, 2022
JackBoosY
suggested changes
May 18, 2022
JackBoosY
added
requires:author-response
category:community-triplet
JackBoosY
suggested changes
May 18, 2022
JackBoosY
suggested changes
May 18, 2022
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/angle/vcpkg.json
Valid values for the license field can be found in the documentation
JackBoosY
approved these changes
May 18, 2022
|
Thanks for the fix! |
This was referenced May 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Fixes angle build on macos
#24396
#23941
Which triplets are supported/not supported?
x64-osx
x64-osx-dynamic
x64-osx-static