-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Initial addition of CLI Reference docs #24754
[docs] Initial addition of CLI Reference docs #24754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please excuse extreme nitpicks. I think the big overall themes are:
- Passive voice is bad.
- I think we should consistently use "port" when that's what we're talking about in new docs.
- Not wanting to codify "all commands accept Xxx" for commands that do nothing with those values.
Also I think it would be good for Augustin to at least read this.
Waiting for #24764 so I can get some validation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments throughout the files.
docs/commands/common-options.md
Outdated
|
||
<a name="x-asset-sources"></a> | ||
|
||
## `--x-asset-sources=<config>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move experimental options to the bottom of the list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the x-
prefix should be treated like the
when sorting phrases.
The intended path of experimental functionality (90% of the time) is to drop the prefix when stable and continue accepting the old name. This ensures maximum compatibility with existing scripts.
We could consider an entirely separate section for experimental functionality, but I feel that's unnecessary and unusual as long as they're clearly marked.
This PR introduces a Command Line Reference section to the documentation along with the first documented command (
install
).