Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Initial addition of CLI Reference docs #24754

Merged
merged 7 commits into from
May 27, 2022

Conversation

ras0219-msft
Copy link
Contributor

This PR introduces a Command Line Reference section to the documentation along with the first documented command (install).

This was referenced May 17, 2022
@Cheney-W Cheney-W self-assigned this May 18, 2022
@Cheney-W Cheney-W added the category:documentation To resolve the issue, documentation will need to be updated label May 18, 2022
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please excuse extreme nitpicks. I think the big overall themes are:

  • Passive voice is bad.
  • I think we should consistently use "port" when that's what we're talking about in new docs.
  • Not wanting to codify "all commands accept Xxx" for commands that do nothing with those values.

Also I think it would be good for Augustin to at least read this.

docs/commands/common-options.md Outdated Show resolved Hide resolved
docs/commands/common-options.md Outdated Show resolved Hide resolved
docs/commands/install.md Outdated Show resolved Hide resolved
docs/commands/common-options.md Outdated Show resolved Hide resolved
docs/commands/common-options.md Outdated Show resolved Hide resolved
docs/commands/install.md Outdated Show resolved Hide resolved
docs/commands/install.md Outdated Show resolved Hide resolved
docs/commands/install.md Outdated Show resolved Hide resolved
docs/commands/install.md Outdated Show resolved Hide resolved
docs/commands/install.md Show resolved Hide resolved
@ras0219-msft
Copy link
Contributor Author

Waiting for #24764 so I can get some validation :)

Copy link
Contributor

@AugP AugP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments throughout the files.

docs/commands/common-options.md Outdated Show resolved Hide resolved

<a name="x-asset-sources"></a>

## `--x-asset-sources=<config>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move experimental options to the bottom of the list?

Copy link
Contributor Author

@ras0219-msft ras0219-msft May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the x- prefix should be treated like the when sorting phrases.

The intended path of experimental functionality (90% of the time) is to drop the prefix when stable and continue accepting the old name. This ensures maximum compatibility with existing scripts.

We could consider an entirely separate section for experimental functionality, but I feel that's unnecessary and unusual as long as they're clearly marked.

docs/commands/common-options.md Outdated Show resolved Hide resolved
docs/commands/install.md Outdated Show resolved Hide resolved
docs/commands/install.md Outdated Show resolved Hide resolved
docs/commands/install.md Outdated Show resolved Hide resolved
docs/commands/install.md Outdated Show resolved Hide resolved
docs/commands/install.md Outdated Show resolved Hide resolved
docs/users/manifests.md Show resolved Hide resolved
docs/users/manifests.md Show resolved Hide resolved
@ras0219-msft ras0219-msft requested a review from BillyONeal May 26, 2022 20:35
@ras0219-msft ras0219-msft merged commit 36b6831 into microsoft:master May 27, 2022
@ras0219-msft ras0219-msft deleted the dev/roschuma/docs-cli branch May 27, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants