[hdf5] Update to 1.12.2 #24758

Thieum · 2022-05-17T20:13:50Z

Updates hdf5 to 1.12.2 : https://github.com/HDFGroup/hdf5/releases/tag/hdf5-1_12_2

What does your PR fix?

Updates hdf5 to 1.12.2

Which triplets are supported/not supported? Have you updated the CI baseline?

no change (tested locally on windows), N/A

Does your PR follow the maintainer guide?

Yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/hdf5/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/hdf5/vcpkg.json

Valid values for the license field can be found in the documentation

JonLiu1993 · 2022-05-18T06:28:40Z

@Thieum ,Thanks for your pr, looks ci tested failed on many triplet
This is error log, please take a look:

CMake Error at /mnt/vcpkg-ci/installed/x64-linux/share/hdf5/vcpkg-cmake-wrapper.cmake:17 (_find_package):
  Could not find a package configuration file provided by "HDF5" with any of
  the following names:

    HDF5Config.cmake
    hdf5-config.cmake

  Add the installation prefix of "HDF5" to CMAKE_PREFIX_PATH or set
  "HDF5_DIR" to a directory containing one of the above files.  If "HDF5"
  provides a separate development package or SDK, be sure it has been
  installed.

ports/hdf5/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for hdf5 have changed but the version was not updated
version: 1.12.2
old SHA: ce3e47d9a7157548c3213c7c4b3d4e8a1fdbc12a
new SHA: b74658ab825f76c17f40808d2e8f75fc83a91dd0
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/hdf5/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/hdf5/vcpkg.json

Valid values for the license field can be found in the documentation

Thieum · 2022-05-18T17:54:44Z

@JonLiu1993 Is the comment at the top of ports\hdf5\portfile.cmake still valid?

# highfive should be updated together with hdf5

Should I update it in the same PR? Here is the latest release: https://github.com/BlueBrain/HighFive/releases/tag/v2.4.1

JonLiu1993 · 2022-05-19T02:11:26Z

@JonLiu1993 Is the comment at the top of ports\hdf5\portfile.cmake still valid?

# highfive should be updated together with hdf5

Should I update it in the same PR? Here is the latest release: https://github.com/BlueBrain/HighFive/releases/tag/v2.4.1

@Thieum, Looks CI test successfully , you can update hdf5 to v2.4.1 and commit a new pr. Thanks!

JonLiu1993 · 2022-05-20T08:18:51Z

@Thieum ,I tested the features on my locally machine by command "./vcpkg install hdf5[*]:x86-windows" but failed,
There is error log, pleasae take a look:

CMake Error at config/cmake_ext_mod/HDFUseFortran.cmake:16 (enable_language):
  No CMAKE_Fortran_COMPILER could be found.

  Tell CMake where to find the compiler by setting either the environment
  variable "FC" or the CMake cache entry CMAKE_Fortran_COMPILER to the full
  path to the compiler, or to the compiler name if it is in the PATH.
Call Stack (most recent call first):
  CMakeLists.txt:1066 (include)

Neumann-A · 2022-05-20T10:06:30Z

@JonLiu1993 That is ok. (If you are only testing on windows)

JonLiu1993 · 2022-05-20T10:35:32Z

@JonLiu1993 That is ok. (If you are only testing on windows)

@Neumann-A, I re-tested the feature locally, I excluded the fortran feature, and the command ./vcpkg install hdf5[cpp,parallel,szip,threadsafe,tools,utils,zlib] still failed, this is the error log:

-- Fixing pkgconfig file: F:/Feature-test/tree-sitter/vcpkg/packages/hdf5_x86-windows/lib/pkgconfig/hdf5_cpp.pc
-- Fixing pkgconfig file: F:/Feature-test/tree-sitter/vcpkg/packages/hdf5_x86-windows/lib/pkgconfig/hdf5_hl.pc
-- Fixing pkgconfig file: F:/Feature-test/tree-sitter/vcpkg/packages/hdf5_x86-windows/lib/pkgconfig/hdf5_hl_cpp.pc
-- Using cached msys-mingw-w64-i686-pkg-config-0.29.2-3-any.pkg.tar.zst.
-- Using cached msys-mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst.
-- Using msys root at F:/Feature-test/tree-sitter/vcpkg/downloads/tools/msys2/9a1ec3f33446b195
-- Fixing pkgconfig file: F:/Feature-test/tree-sitter/vcpkg/packages/hdf5_x86-windows/debug/lib/pkgconfig/hdf5.pc
-- Fixing pkgconfig file: F:/Feature-test/tree-sitter/vcpkg/packages/hdf5_x86-windows/debug/lib/pkgconfig/hdf5_cpp.pc
-- Fixing pkgconfig file: F:/Feature-test/tree-sitter/vcpkg/packages/hdf5_x86-windows/debug/lib/pkgconfig/hdf5_hl.pc
-- Fixing pkgconfig file: F:/Feature-test/tree-sitter/vcpkg/packages/hdf5_x86-windows/debug/lib/pkgconfig/hdf5_hl_cpp.pc
CMake Error at scripts/cmake/vcpkg_copy_tools.cmake:70 (message):
  Couldn't find tool "h5perf_serial":

      "F:/Feature-test/vcpkg/packages/hdf5_x86-windows/bin/h5perf_serial.exe" does not exist
Call Stack (most recent call first):
  ports/hdf5/portfile.cmake:120 (vcpkg_copy_tools)
  scripts/ports.cmake:146 (include)


error: building hdf5:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
    https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+hdf5
You can submit a new issue at:
    https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[hdf5]+Build+error
Include '[hdf5] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
    vcpkg-tool version: 2022-05-05-67e17c1782801cf481be9ac0b3765dff3e4bdeb8
    vcpkg-scripts version: 3d0cfc7a1 2022-05-18 (2 days ago)

Thieum · 2022-05-24T15:41:36Z

@JonLiu1993 added a guard for the optional tool.

ports/hdf5/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: unable to parse versions file /home/runner/work/vcpkg/vcpkg/versions/h-/hdf5.json
Error: failed to parse versions file for `hdf5`: :8:17: error: Unexpected character in middle of array
    on expression:       "git-tree": "c6491dde27884b1326e6f74f3862c1ae63a122ca",
                                   ^

see HDFGroup/hdf5#860

dg0yt

Thanks for the update!

ports/hdf5/portfile.cmake

Thieum · 2022-06-03T19:26:24Z

@JonLiu1993 I think all the comments have been fixed. Let me know if anything else can be improved!

JonLiu1993 · 2022-06-06T07:47:15Z

All features are tested successufully in the following triplet:

x86-windows
x64-windows
x64-windows-static

ras0219-msft · 2022-06-06T19:37:58Z

Thanks for the update!

Thieum added 2 commits May 17, 2022 16:08

[hdf5] Update to 1.12.2

6c5ab17

Update hdf5.json

af01f8f

github-actions bot approved these changes May 17, 2022

View reviewed changes

Thieum added 2 commits May 17, 2022 16:45

add new tool to list

c2eb739

Update hdf5.json

55fd20d

github-actions bot approved these changes May 17, 2022

View reviewed changes

Cheney-W assigned JonLiu1993 May 18, 2022

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 18, 2022

Neumann-A reviewed May 18, 2022

View reviewed changes

ports/hdf5/portfile.cmake Outdated Show resolved Hide resolved

revert hdf5 subdir in share + special tool

b01944a

github-actions bot requested changes May 18, 2022

View reviewed changes

Update hdf5.json

aef814a

github-actions bot approved these changes May 18, 2022

View reviewed changes

Thieum added 3 commits May 18, 2022 13:59

add license (null -> custom license)

23e9b87

formatting

10125c7

Update hdf5.json

3d0cfc7

github-actions bot approved these changes May 18, 2022

View reviewed changes

Thieum marked this pull request as ready for review May 19, 2022 12:40

JonLiu1993 added the requires:author-response label May 20, 2022

Thieum added 2 commits May 24, 2022 11:20

tool is optional

3d856db

Update hdf5.json

d994629

github-actions bot approved these changes May 24, 2022

View reviewed changes

fix guard

72d7605

Update hdf5.json

3f4574a

github-actions bot approved these changes May 24, 2022

View reviewed changes

dg0yt suggested changes May 25, 2022

View reviewed changes

ports/hdf5/portfile.cmake Outdated Show resolved Hide resolved

ports/hdf5/portfile.cmake Outdated Show resolved Hide resolved

LilyWangLL mentioned this pull request May 27, 2022

[hdf5] Build error for Windows Arm64 platforms #24898

Closed

Thieum added 2 commits June 2, 2022 17:08

attempt to make hdf5perf tool dependent on feature

eb62337

Update hdf5.json

a016ed7

github-actions bot approved these changes Jun 2, 2022

View reviewed changes

Merge branch 'master' into hdf5-1.12.2

545e733

github-actions bot requested changes Jun 3, 2022

View reviewed changes

Thieum added 2 commits June 3, 2022 08:25

fix hdf5.json

1fd3564

Update hdf5.json

46cc100

github-actions bot approved these changes Jun 3, 2022

View reviewed changes

Thieum added 2 commits June 3, 2022 08:42

remove parallel patch per comment

e19ae1e

see HDFGroup/hdf5#860

Update hdf5.json

a0d6426

github-actions bot approved these changes Jun 3, 2022

View reviewed changes

dg0yt suggested changes Jun 3, 2022

View reviewed changes

ports/hdf5/portfile.cmake Outdated Show resolved Hide resolved

Thieum added 2 commits June 3, 2022 09:59

fix MATCHES vs IN_LIST

6bc2139

Update hdf5.json

a2f8c54

github-actions bot approved these changes Jun 3, 2022

View reviewed changes

JonLiu1993 removed the requires:author-response label Jun 6, 2022

JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 6, 2022

ras0219-msft approved these changes Jun 6, 2022

View reviewed changes

ras0219-msft merged commit 57ef47d into microsoft:master Jun 6, 2022

Thieum deleted the hdf5-1.12.2 branch July 7, 2022 19:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hdf5] Update to 1.12.2 #24758

[hdf5] Update to 1.12.2 #24758

Thieum commented May 17, 2022

github-actions bot left a comment

github-actions bot left a comment

JonLiu1993 commented May 18, 2022

github-actions bot left a comment

github-actions bot left a comment

Thieum commented May 18, 2022

JonLiu1993 commented May 19, 2022

JonLiu1993 commented May 20, 2022

Neumann-A commented May 20, 2022

JonLiu1993 commented May 20, 2022

Thieum commented May 24, 2022

github-actions bot left a comment

dg0yt left a comment

Thieum commented Jun 3, 2022

JonLiu1993 commented Jun 6, 2022

ras0219-msft commented Jun 6, 2022

[hdf5] Update to 1.12.2 #24758

[hdf5] Update to 1.12.2 #24758

Conversation

Thieum commented May 17, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented May 18, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Thieum commented May 18, 2022

JonLiu1993 commented May 19, 2022

JonLiu1993 commented May 20, 2022

Neumann-A commented May 20, 2022

JonLiu1993 commented May 20, 2022

Thieum commented May 24, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

dg0yt left a comment

Choose a reason for hiding this comment

Thieum commented Jun 3, 2022

JonLiu1993 commented Jun 6, 2022

ras0219-msft commented Jun 6, 2022

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?